Vitor de Lima has posted comments on this change.
Change subject: core, engine, webadmin: Initial support for alternative
architectures
......................................................................
Patch Set 8:
(3 comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
Line 59: vm.display.smartcard_enabled: xs:boolean
Line 60: vm.display.keyboard_layout: xs:string
Line 61: vm.os.cmdline: xs:string
Line 62: vm.cpu.mode: xs:string
Line 63: vm.cpu.architecture: xs:string
The main problem is that the architecture is an attribute obtained from the
cluster where the VM was created. I am still in doubt about how to handle this.
I would like to have some feedback on this issue.
When creating or updating a VM, the VM's architecture must be the same as the
architecture of the target cluster, but I don't know if the user should
optionally supply an architecture and the engine should validate his choice
(i.e. if it should report an error if the user chooses an architecture which
does not match the cluster), or if the engine should ignore always his choice
(this option seems to be counter-intuitive). Anyway, the user must be able to
know the architecture of each entity he receives from the API.
Currently, in this patch, the engine ignores the user's choice and always
resolves the architecture internally, so every Mapper class do not have a
API->Engine mapping.
In the RSDL I thought every parameter should be either optional or mandatory,
so I decided to put it as an optional parameter. What happens if this parameter
(the architecture) is not listed in the RSDL?
How do you think this parameter should be implemented? Should it be "mapped" in
both ways (Engine -> API, API -> Engine)? Should the internal Add* commands
report a mismatch between the chosen architecture and the the selected cluster?
Should it be marked as strictly immutable?
Line 64: vm.cpu.topology.cores: xs:int
Line 65: vm.cpu_shares: xs:int
Line 66: vm.memory: xs:long
Line 67: vm.high_availability.priority: xs:int
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java
Line 414: obj.setVdsGroupName(instance.getVdsGroupName());
Line 415: obj.setVmType(instance.getVmType());
Line 416: obj.setId(instance.getId());
Line 417: obj.setDiskList(instance.getDiskList());
Line 418: obj.setRunAndPause(instance.isRunAndPause());
Done
Line 419:
Line 420: return obj;
Line 421: }
Line 422:
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 585: name);
Line 586: }
Line 587: }
Line 588:
Line 589: public void postNameUniqueCheck(UserPortalListModel
userPortalListModel)
Done
Line 590: {
Line 591: UnitVmModel model = (UnitVmModel)
userPortalListModel.getWindow();
Line 592: UserPortalItemModel selectedItem = (UserPortalItemModel)
userPortalListModel.getSelectedItem();
Line 593: VM vm = (VM) selectedItem.getEntity();
--
To view, visit http://gerrit.ovirt.org/16700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33ed9231a6467aa59e8f3223ba9d61b6e68039fa
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
