Michael Pasternak has posted comments on this change.
Change subject: sdk: unclear error message when logging into cli with bad
formatted url
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File src/ovirtcli/command/connect.py
Line 152: regex = re.compile(
Line 153: r'^(?:http)s?://' # http:// or https://
Line 154:
r'(?:(?:[A-Z0-9](?:[A-Z0-9-]{0,61}[A-Z0-9])?\.)+(?:[A-Z]{2,6}\.?|[A-Z0-9-]{2,}\.?)|'
# domain...
Line 155: r'localhost|' # localhost...
Line 156: r'\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}|' # ...or ipv4
this regex will allow entering incomplete/wrong ip addr
Line 157: r'\[?[A-F0-9]*:[A-F0-9:]+\]?)' # ...or ipv6
Line 158: r'(?::\d+)?' # optional port
Line 159: r'(/api)' # /api
Line 160: , re.IGNORECASE)
--
To view, visit http://gerrit.ovirt.org/18621
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3665d8714258ad8e449638fbf0b86105f813e3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
