Vinzenz Feenstra has posted comments on this change. Change subject: Remove contra productive _string_check ......................................................................
Patch Set 1: I have verified this by creating ascii and non-ascii DisplayNames in Windows. Before the removal of the _string_check function the result for non-ascii based unicode strings resulted on an english windows in non-unicode strings which failed in the new unicode verification code, because it enforces unicode types. Previously I have tested this on a Chinese windows where this did not trigger the behaviour due to the fact that the locale used in the _string_check function was correct for the strings received. After this change the behaviour is working on chinese locae and on an english locale on Windows. -- To view, visit http://gerrit.ovirt.org/18811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id01d8dc1374ae33435c5aefaae559ab8aa0ff062 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
