Allon Mureinik has posted comments on this change.

Change subject: restapi: compare to Boolean with equals
......................................................................


Patch Set 1: Code-Review-1

sorry, premature publish...

Can isRequired() be null?
The original code does not assume so - yours does.

If this assumption is OK, just use
!link1.getRequest().getBody().isRequired()

If it's not OK, you should use
Boolean.False.equals(link1.getRequest().getBody().isRequired())

-- 
To view, visit http://gerrit.ovirt.org/18824
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7f0738730552bb8d2b935551bf9fcf938971834
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to