Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: added branding cascading resource servlet ......................................................................
Patch Set 4: (1 comment) .................................................... File packaging/branding/ovirt.brand/branding.properties Line 18: messages=messages.properties Line 19: Line 20: # resources -- images, PDFs, etc. These are cascaded, so if the same resource Line 21: # exists in a higher brand, the higher brand "wins" and gets served. Line 22: favicon=images/favicon.ico I am probably missing something here, but can't this be added to messages.properties (or to resources.properties, once http://gerrit.ovirt.org/#/c/18623/ is merged)? Line 23: Line 24: # Welcome page template (optional, allows you to add things to the welcome page) Line 25: welcome=welcome_page.template Line 26: -- To view, visit http://gerrit.ovirt.org/18385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dcd9d0f22a7c5867c39576020ad16dd6c53deda Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
