Allon Mureinik has posted comments on this change.
Change subject: engine: Removes not used image groups after snapshot removal
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
Line 176: if
(imageIdsUsedByActiveSnapshot.contains(diskImage.getId()) ||
Line 177:
removeInProcessImageIds.contains(diskImage.getId())) {
Line 178: continue;
Line 179: }
Line 180:
You should persist the placeholders before running the task, AFAIK.
Line 181: VdcReturnValueBase retValue =
runAsyncTask(VdcActionType.RemoveImage,
Line 182: new
RemoveImageParameters(diskImage.getImageId()));
Line 183:
Line 184: if (retValue.getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/18647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07928bc8ff4225055586b96e47d3787d741a95b4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
