Hello Patrick, you're right about the rulesToObject and objectToRules functions. I'll move them into rules.jsm.
Writing the rules file to disk in backupPrefs will result in two files. One with the saved Enigmail preferences and the pgpRules.xml. As I understand ticket #469 the use case for the save/restore function is to help users to install a certain configuration instead of guiding them through the advanced tab. Forcing the user to send and afterwards load two files makes the whole process error-prone. Regards Kai On 07/14/2015 05:36 PM, Patrick Brunschwig wrote: > On 14.07.2015 14:09, Kai Michaelis wrote: >> This patch extends the save/restore profile function so that it saves >> the contents of pgpRules.xml too. When restoring a saved profile all >> existing per-recipient rules are _deleted_ and replaced with the ones >> in the saved profile. > > Hi Kai > > From what I can see, you put a lot of logic into pref-enigmail.js that > should go into rules.jsm (or that actually is already there!). > > We should avoid to duplicate code. > > Why don't you simply write the rules file to disk, and and use the > existing EnigmailRules.loadRulesFile() to get them loaded? > > -Patrick > > > > _______________________________________________ > enigmail-users mailing list > enigmail-users@enigmail.net > To unsubscribe or make changes to your subscription click here: > https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net > _______________________________________________ enigmail-users mailing list enigmail-users@enigmail.net To unsubscribe or make changes to your subscription click here: https://admin.hostpoint.ch/mailman/listinfo/enigmail-users_enigmail.net
