Enlightenment CVS committal
Author : onefang
Project : e17
Module : libs/ecore
Dir : e17/libs/ecore/src/lib/ecore
Modified Files:
ecore_exe.c
Log Message:
Remove the kill_maybe that slipped in a while ago.
===================================================================
RCS file: /cvsroot/enlightenment/e17/libs/ecore/src/lib/ecore/ecore_exe.c,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -3 -r1.19 -r1.20
--- ecore_exe.c 29 Nov 2005 12:39:09 -0000 1.19
+++ ecore_exe.c 29 Nov 2005 22:22:21 -0000 1.20
@@ -225,11 +225,11 @@
/* Something went 'orribly wrong. */
vfork_exec_errno = errno;
-// if (! (flags & ECORE_EXE_PIPE_READ))
-// close(dataPipe[1]); /* FIXME: Check for -1 then errno. */
-// if (! (flags & ECORE_EXE_PIPE_WRITE))
-// close(dataPipe[0]); /* FIXME: Check for -1 then errno. */
-// close(statusPipe[1]); /* FIXME: Check for -1 then errno. */
+ if (! (flags & ECORE_EXE_PIPE_READ))
+ close(dataPipe[1]); /* FIXME: Check for -1 then errno. */
+ if (! (flags & ECORE_EXE_PIPE_WRITE))
+ close(dataPipe[0]); /* FIXME: Check for -1 then errno. */
+ close(statusPipe[1]); /* FIXME: Check for -1 then errno. */
_exit(-1);
}
else /* parent */
@@ -429,25 +429,6 @@
*/
/**
- * Makes sure the process is dead, one way or another.
- * @param exe Process handle to the given process.
- * @ingroup Ecore_Exe_Signal_Group
- */
-void
-ecore_exe_kill_maybe(Ecore_Exe *exe)
-{
- if (!ECORE_MAGIC_CHECK(exe, ECORE_MAGIC_EXE))
- {
- /* Since Ecore_Exe's can be freed without the users knowledge, we need
a way to kill them without bitchin'. */
- /* FIXME: On the other hand, handling the exe exit event may be the way
to go. */
- return;
- }
- kill(exe->pid, SIGTERM);
-/* FIXME: should pause for a bit. */
- kill(exe->pid, SIGKILL);
-}
-
-/**
* Pauses the given process by sending it a @c SIGSTOP signal.
* @param exe Process handle to the given process.
* @ingroup Ecore_Exe_Signal_Group
@@ -580,7 +561,6 @@
{
void *data;
-printf("FREEING Ecore_Exe %s\n", exe->cmd);
data = exe->data;
/* FIXME: close fdhanlders and free buffers if they exist */
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
