Enlightenment CVS committal
Author : onefang
Project : e17
Module : libs/ecore
Dir : e17/libs/ecore/src/lib/ecore
Modified Files:
ecore_exe.c
Log Message:
Just another excuse to terminate those pesky exe's.
===================================================================
RCS file: /cvsroot/enlightenment/e17/libs/ecore/src/lib/ecore/ecore_exe.c,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -3 -r1.29 -r1.30
--- ecore_exe.c 1 Jan 2006 20:09:47 -0000 1.29
+++ ecore_exe.c 1 Jan 2006 21:20:42 -0000 1.30
@@ -402,7 +402,7 @@
if (!ok)
{ /* Something went wrong, so pull down everything. */
- /* FIXME: should kill it if it managed to start up. */
+ if (exe->pid) ecore_exe_terminate(exe);
IF_FN_DEL(_ecore_exe_free, exe);
}
else
@@ -1035,7 +1035,14 @@
{
if (exe->read_data_size)
printf("There are %d bytes left unsent from the
dead exe %s.\n", exe->read_data_size, exe->cmd);
- ecore_exe_terminate(exe); /* FIXME: give this
some deep thought later. */
+ /* Thought about this a bit. If the exe has
actually
+ * died, this won't do any harm as it must have died
+ * recently and the pid has not had a chance to
recycle.
+ * It is also a paranoid catchall, coz the usual
ecore_signal
+ * mechenism should kick in. But let's give it a
good
+ * kick anyway.
+ */
+ ecore_exe_terminate(exe);
}
break;
}
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
