Enlightenment CVS committal Author : rbdpngn Project : e17 Module : libs/ewl
Dir : e17/libs/ewl/src/lib Modified Files: ewl_events.c Log Message: Convert another event dispatching function to use window instead of embed API, add a comment so we remember why it's setup this way. =================================================================== RCS file: /cvsroot/enlightenment/e17/libs/ewl/src/lib/ewl_events.c,v retrieving revision 1.22 retrieving revision 1.23 diff -u -3 -r1.22 -r1.23 --- ewl_events.c 12 Mar 2006 21:24:40 -0000 1.22 +++ ewl_events.c 13 Mar 2006 15:01:20 -0000 1.23 @@ -157,6 +157,15 @@ #ifdef ENABLE_EWL_SOFTWARE_X11 +/* + * In general all of the X event handlers should find their matching window + * with ewl_window_window_find, and not ewl_embed_evas_window_find. If the + * embed function is used, then we get duplicate events for apps that setup + * their own handlers and embed EWL. The exception to this is selection events + * such as copy/paste and DND. These events need to be handled for embedded + * EWL, but have no equivalent in the Evas callback namespace. + */ + /** * @param data: user specified data passed to the function * @param type: the type of event triggering the function call @@ -174,18 +183,18 @@ * let them know in case a widget is using a non-evas based draw method */ Ecore_X_Event_Window_Damage *ev; - Ewl_Embed *embed; + Ewl_Window *window; DENTER_FUNCTION(DLEVEL_STABLE); ev = e; - embed = ewl_embed_evas_window_find((void *)ev->win); - if (!embed) + window = ewl_window_window_find((void *)ev->win); + if (!window) DRETURN_INT(TRUE, DLEVEL_STABLE); - evas_damage_rectangle_add(embed->evas, ev->x, ev->y, ev->w, ev->h); - ewl_callback_call(EWL_WIDGET(embed), EWL_CALLBACK_EXPOSE); + evas_damage_rectangle_add(EWL_EMBED(window)->evas, ev->x, ev->y, ev->w, ev->h); + ewl_callback_call(EWL_WIDGET(window), EWL_CALLBACK_EXPOSE); DRETURN_INT(TRUE, DLEVEL_STABLE); } ------------------------------------------------------- This SF.Net email is sponsored by xPML, a groundbreaking scripting language that extends applications into web and mobile media. Attend the live webcast and join the prime developer group breaking into this new coding territory! http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642 _______________________________________________ enlightenment-cvs mailing list enlightenment-cvs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs