Enlightenment CVS committal
Author : sebastid
Project : e17
Module : libs/ecore
Dir : e17/libs/ecore/src/lib/ecore_desktop
Modified Files:
ecore_desktop.c ecore_desktop_icon.c ecore_desktop_menu.c
ecore_desktop_xmlame.c
Log Message:
Fix mem leaks.
===================================================================
RCS file: /cvs/e/e17/libs/ecore/src/lib/ecore_desktop/ecore_desktop.c,v
retrieving revision 1.44
retrieving revision 1.45
diff -u -3 -r1.44 -r1.45
--- ecore_desktop.c 23 Sep 2006 10:47:15 -0000 1.44
+++ ecore_desktop.c 24 Sep 2006 09:28:21 -0000 1.45
@@ -743,9 +743,9 @@
IFFREE(desktop->window_name);
IFFREE(desktop->window_title);
IFFREE(desktop->window_role);
- IFFREE(desktop->NotShowIn);
- IFFREE(desktop->OnlyShowIn);
- IFFREE(desktop->Categories);
+ if (desktop->NotShowIn) ecore_hash_destroy(desktop->NotShowIn);
+ if (desktop->OnlyShowIn) ecore_hash_destroy(desktop->OnlyShowIn);
+ if (desktop->Categories) ecore_hash_destroy(desktop->Categories);
if (desktop->data)
{
ecore_hash_destroy(desktop->data);
===================================================================
RCS file: /cvs/e/e17/libs/ecore/src/lib/ecore_desktop/ecore_desktop_icon.c,v
retrieving revision 1.34
retrieving revision 1.35
diff -u -3 -r1.34 -r1.35
--- ecore_desktop_icon.c 23 Sep 2006 11:23:43 -0000 1.34
+++ ecore_desktop_icon.c 24 Sep 2006 09:28:21 -0000 1.35
@@ -575,6 +575,8 @@
free(icon_theme->directories);
if (icon_theme->Directories)
ecore_list_destroy(icon_theme->Directories);
+ if (icon_theme->Inherits)
+ ecore_list_destroy(icon_theme->Inherits);
free(icon_theme);
}
===================================================================
RCS file: /cvs/e/e17/libs/ecore/src/lib/ecore_desktop/ecore_desktop_menu.c,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -3 -r1.20 -r1.21
--- ecore_desktop_menu.c 23 Sep 2006 09:32:27 -0000 1.20
+++ ecore_desktop_menu.c 24 Sep 2006 09:28:21 -0000 1.21
@@ -315,10 +315,10 @@
{
E_FN_DEL(ecore_desktop_tree_del, (merge_stack));
}
- E_FREE(data.path);
- E_FREE(data.base);
- E_FN_DEL(ecore_desktop_tree_del, (data.stack));
}
+ E_FN_DEL(ecore_desktop_tree_del, (data.stack));
+ E_FREE(data.path);
+ E_FREE(data.base);
return menu_xml;
}
===================================================================
RCS file: /cvs/e/e17/libs/ecore/src/lib/ecore_desktop/ecore_desktop_xmlame.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -3 -r1.6 -r1.7
--- ecore_desktop_xmlame.c 23 Sep 2006 10:01:17 -0000 1.6
+++ ecore_desktop_xmlame.c 24 Sep 2006 09:28:21 -0000 1.7
@@ -64,6 +64,7 @@
ecore_desktop_tree_extend(tree, file);
_ecore_desktop_xmlame_parse(tree, buffer);
}
+ //FIXME: free(buffer);
}
return tree;
}
@@ -89,7 +90,7 @@
t = *buffer;
*buffer = '\0';
- ecore_desktop_tree_extend(tree, strdup(text));
+ ecore_desktop_tree_extend(tree, text);
*buffer = t;
}
if (*buffer != '\0')
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
