Enlightenment CVS committal
Author : rephorm
Project : e17
Module : libs/ecore
Dir : e17/libs/ecore/src/lib/ecore_desktop
Modified Files:
ecore_desktop.c ecore_desktop_icon.c ecore_desktop_menu.c
Log Message:
remove some unneeded casts, and unused code
add a fixme
===================================================================
RCS file: /cvs/e/e17/libs/ecore/src/lib/ecore_desktop/ecore_desktop.c,v
retrieving revision 1.70
retrieving revision 1.71
diff -u -3 -r1.70 -r1.71
--- ecore_desktop.c 15 Dec 2006 05:44:18 -0000 1.70
+++ ecore_desktop.c 21 Dec 2006 03:36:27 -0000 1.71
@@ -132,7 +132,6 @@
}
}
- buffer[0] = (char)0;
fclose(f);
return result;
===================================================================
RCS file: /cvs/e/e17/libs/ecore/src/lib/ecore_desktop/ecore_desktop_icon.c,v
retrieving revision 1.46
retrieving revision 1.47
diff -u -3 -r1.46 -r1.47
--- ecore_desktop_icon.c 12 Nov 2006 02:51:49 -0000 1.46
+++ ecore_desktop_icon.c 21 Dec 2006 03:36:27 -0000 1.47
@@ -448,7 +448,7 @@
theme_path = strdup(icon_theme);
theme_dir = ecore_file_get_dir(theme_path);
if (theme_dir)
- icon_theme = (char *)ecore_file_get_file(theme_dir);
+ icon_theme = ecore_file_get_file(theme_dir);
#ifdef DEBUG
printf("LOADING THEME %s - %s\n", icon_theme, theme_path);
#endif
@@ -483,7 +483,7 @@
/* According to the spec, name and comment are required, but we can fake
those easily enough. */
value = ecore_hash_get(result->group, "Name");
- if (!value) value = (char *) icon_theme;
+ if (!value) value = icon_theme;
result->name = strdup(value);
value = ecore_hash_get(result->group, "Comment");
if (!value) value = "No comment provided.";
===================================================================
RCS file: /cvs/e/e17/libs/ecore/src/lib/ecore_desktop/ecore_desktop_menu.c,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -3 -r1.37 -r1.38
--- ecore_desktop_menu.c 20 Dec 2006 19:50:37 -0000 1.37
+++ ecore_desktop_menu.c 21 Dec 2006 03:36:27 -0000 1.38
@@ -936,6 +936,7 @@
{
if (tree->elements[i].type == ECORE_DESKTOP_TREE_ELEMENT_TYPE_STRING)
{
+ /* FIXME <All /> or <All foo="bar"> would be valid input (which
this won't catch) */
if (strcmp((char *)tree->elements[i].element, "<All/") == 0)
{
sprintf(temp, "%c%cA", type, sub_type);
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
