Enlightenment CVS committal
Author : ningerso
Project : e17
Module : libs/ewl
Dir : e17/libs/ewl/src/bin/tests/widget
Modified Files:
ewl_widget.c
Log Message:
Commentary on failing tests.
Fixed one test that was failing on an incorrect check.
===================================================================
RCS file: /cvs/e/e17/libs/ewl/src/bin/tests/widget/ewl_widget.c,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -3 -r1.15 -r1.16
--- ewl_widget.c 11 Nov 2007 08:03:40 -0000 1.15
+++ ewl_widget.c 11 Nov 2007 08:28:05 -0000 1.16
@@ -500,6 +500,8 @@
ewl_widget_unrealize(w);
if (VISIBLE(w))
+ /* This is the currently expected behavior, but we're discussing
+ * if this is really the behavior we want */
snprintf(buf, len, "Widget VISIBLE after realize/unrealize");
else if (REALIZED(w))
snprintf(buf, len, "Widget REALIZED after realize/unrealize");
@@ -556,8 +558,11 @@
snprintf(buf, len, "Parent NULL after parent_set");
else if (!VISIBLE(w))
snprintf(buf, len, "Widget !VISIBLE after parent_set");
- else if (!REALIZED(w))
- snprintf(buf, len, "Widget !REALIZED after parent_set");
+ else if (REALIZED(w))
+ /* The widget has not been realized yet as that happens in the
+ * idle loop, so this should test that it is still not realized
+ * after changing parents. */
+ snprintf(buf, len, "Widget REALIZED after parent_set");
else if (REVEALED(w))
snprintf(buf, len, "Widget REVEALED after parent_set");
else
@@ -627,6 +632,8 @@
else if (!VISIBLE(w))
snprintf(buf, len, "Widget !VISIBLE after reparent");
else if (!REALIZED(w))
+ /* FIXME: This can't possibly be REALIZED, since there is no
+ * top level parent. */
snprintf(buf, len, "Widget !REALIZED after reparent");
else if (REVEALED(w))
snprintf(buf, len, "Widget REVEALED after reparent");
@@ -674,6 +681,8 @@
ewl_widget_reveal(w);
if (VISIBLE(w))
+ /* Realize presently triggers a show, so this is presently the
+ * correct behavior but it is up for discussion right now. */
snprintf(buf, len, "Widget VISIBLE after
realize/reveal/obscure");
else if (!REALIZED(w))
snprintf(buf, len, "Widget !REALIZED after
realize/reveal/obscure");
@@ -698,6 +707,8 @@
ewl_widget_unrealize(w);
if (VISIBLE(w))
+ /* This is another case where the realize has caused the show.
+ * Since that occurs, being VISIBLE is correct. */
snprintf(buf, len, "Widget VISIBLE after
realize/reveal/unrealize");
else if (REALIZED(w))
snprintf(buf, len, "Widget REALIZED after
realize/reveal/unrealize");
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
enlightenment-cvs mailing list
enlightenment-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
