On Saturday, 15 January 2005, at 20:55:39 (-0800),
E CVS List wrote:

> Log Message:
> timeout was wrong... and we shoudl consider DIY cmd-line parsing... see 
> comment

>       case 0:
> +        _entrance_x_sa.sa_handler = SIG_IGN;
> +        _entrance_x_sa.sa_flags = 0;
> +        sigemptyset(&_entrance_x_sa.sa_mask);
>          sigaction(SIGUSR1, &_entrance_x_sa, NULL);
> +      /* FIXME: need to parse command and NOT go thru /bin/sh!!!! */
> +      /* why? some /bin/sh's wont pass on this SIGUSR1 thing... */
>          execl("/bin/sh", "/bin/sh", "-c", x_cmd, NULL);

The spiftool_split() function from LibAST does exactly this:  split a
line into tokens using whitespace with support for quoting.  Using it
to create the execl() parameters would eliminate the need for /bin/sh
altogether.

Michael

-- 
Michael Jennings (a.k.a. KainX)  http://www.kainx.org/  <[EMAIL PROTECTED]>
n + 1, Inc., http://www.nplus1.net/       Author, Eterm (www.eterm.org)
-----------------------------------------------------------------------
 "She'd still say, 'I love you' if I asked, but she never volunteers.
  Somehow what she never says means more than all the other words I
  hear."                     -- BlackHawk, "I Sure Can Smell the Rain"


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to