Hello again !
* Sebastian Dransfeld ([EMAIL PROTECTED]) wrote:
> Hi!
> 
> Two things:
> 
> 1. Why isn't ecore_x_shutdown() and ecore_shutdown() called in 
> entrance_session.c before the exec's?
Probably was just forgotten, omitted, or fell into the category of "it just
didn't work when i put it in its normal spot." We'll see about cleaning it
up though. :)

> 
> 2. I sent at patch a while ago to fix the pam_close_session() problem. I 
> have since checked quickly through the modules included with pam, and it 
> seems no core module is erronous coded. Therefore I think that my patch 
> still is a better way to do it than to simply ignore the error. If it 
> leads to problems, maybe people will fix their pam modules!
ok, my 2cents on this issue.

As for Ibukun's comments last time, I'm not sure of the security
ramifications that exist with this approach, as per my understanding of the
docs your approach is correct.  Unfortunately it doesn't give examples of
what we're tryign to accomplish here.  I'm not sure about the double auth
thing he mentioned either, because the pam_open_session call is only called
when the user's session is executed from entrance_session.c (shit you didn't
even touch).  

I personally haven't had the chance to fully test your patch, and I imagine
Ibukun has been busy lately.  I'll do my best to get some testing on this
patch done in the next few days, and provide my observations.  If all is
well, we'll team up on Ibukun until he gives in. :D

btw, you're going to need to call openlog to use the syslog facitilyt in
entrance_login.

once again, thx for the problem identifications and the patches !

> 
> From the pam guide:
> "It should be possible for sessions to be opened by one application and 
> closed by another. This either requires that the module uses only 
> information obtained from pam_get_item(), or that information regarding 
> the session is stored in some way by the operating system (in a file for 
> example)."
> 
> Regards
> Sebastian


__
Corey Donohoe
http://www.atmos.org


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to