We should have an else condition to the getenv check, if e->display is NULL pam authentication is going to fail miserably. We also prefer 'diff -u' format :D
* Michel Briand ([EMAIL PROTECTED]) wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hello Ibukun > > please chech these files: > > entrance_session.c: fix a segfault when DISPLAY=(null) > > Index: src/client/entrance_session.c > =================================================================== > RCS file: > /cvsroot/enlightenment/e17/apps/entrance/src/client/entrance_session.c,v > retrieving revision 1.67 > diff -r1.67 entrance_session.c > 38c38 > < char *db; > --- > > char *db, *str; > 49,51c49,51 > < if (!display) > < e->display = strdup(getenv("DISPLAY")); > < else > --- > > if (!display) { > > if ((str = getenv("DISPLAY"))) e->display = strdup(str); > > } else __ Corey Donohoe http://www.atmos.org ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel