I got these warnings thru -Wall

e_gadman.c: In function `_e_gadman_client_overlap_deny':
e_gadman.c:721: warning: `gmc2' might be used uninitialized in this function
e_gadman.c:780: warning: `gmc2' might be used uninitialized in this function
e_gadman.c:838: warning: `gmc2' might be used uninitialized in this function

gmc2 was having values assigned after being tested against.  moved before test.


Index: e17/apps/e/src/bin/e_gadman.c
===================================================================
RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_gadman.c,v
retrieving revision 1.24
diff -u -r1.24 e_gadman.c
--- e17/apps/e/src/bin/e_gadman.c       21 Feb 2005 16:16:39 -0000      1.24
+++ e17/apps/e/src/bin/e_gadman.c       14 Mar 2005 02:28:44 -0000
@@ -719,10 +719,10 @@
             for (l = gmc->zone->container->gadman->clients; l; l = l->next)
               {
                  E_Gadman_Client *gmc2;
-                 
+
+                  gmc2 = l->data;
                  if (gmc != gmc2)
                    {
-                      gmc2 = l->data;
                       if ((E_SPANS_COMMON(gmc->x, gmc->w, gmc2->x, gmc2->w)) &&
                           (E_SPANS_COMMON(gmc->y, gmc->h, gmc2->y, gmc2->h)))
                         {
@@ -778,10 +778,10 @@
             for (l = gmc->zone->container->gadman->clients; l; l = l->next)
               {
                  E_Gadman_Client *gmc2;
-                 
+
+                  gmc2 = l->data;
                  if (gmc != gmc2)
                    {
-                      gmc2 = l->data;
                       if ((E_SPANS_COMMON(gmc->x, gmc->w, gmc2->x, gmc2->w)) &&
                           (E_SPANS_COMMON(gmc->y, gmc->h, gmc2->y, gmc2->h)))
                         {
@@ -836,10 +836,10 @@
        for (l = gmc->zone->container->gadman->clients; l; l = l->next)
          {
             E_Gadman_Client *gmc2;
-            
+
+             gmc2 = l->data;
             if (gmc != gmc2)
               {
-                 gmc2 = l->data;
                  if ((E_SPANS_COMMON(gmc->x, gmc->w, gmc2->x, gmc2->w)) &&
                      (E_SPANS_COMMON(gmc->y, gmc->h, gmc2->y, gmc2->h)))
           



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to