[E-devel] PATCH: A wee shading fix

[David Stevenson]

Gidday,

I noticed a minor glitch with the shading animation. When you do a shade  (both double-click on border / ctrl-alt-r will do), and then do another before the first shade animation finishes, the partially shaded window completely unshades then starts shading again. Then when the second shading animation finishes, instead of staying shaded, the window unshades again.
This is easy to see with a shade-speed of 500 or so.

The attached patch prevents ignores shade commands while shading/unshading is already in progress.

Regards!
David

PS, the shade/unshade is quite jerky when I use the ctrl-alt-r keybinding, but quite smooth when I double click the border.
top shows Xorg munching up CPU by about twice as much when I use the keybinding as for when I do a double click. Just my system?

Index: e17/apps/e/src/bin/e_border.c
===================================================================
RCS file: /cvsroot/enlightenment/e17/apps/e/src/bin/e_border.c,v
retrieving revision 1.400
diff -u -r1.400 e_border.c
--- e17/apps/e/src/bin/e_border.c	21 Sep 2005 04:53:12 -0000	1.400
+++ e17/apps/e/src/bin/e_border.c	21 Sep 2005 14:12:29 -0000
@@ -1246,7 +1246,7 @@
 
    E_OBJECT_CHECK(bd);
    E_OBJECT_TYPE_CHECK(bd, E_BORDER_TYPE);
-   if ((bd->fullscreen) || (bd->maximized)) return;
+   if ((bd->fullscreen) || (bd->maximized) || (bd->shading)) return;
    if (!strcmp("borderless", bd->client.border.name)) return;
    if (!bd->shaded)
      {
@@ -1332,7 +1332,7 @@
 
    E_OBJECT_CHECK(bd);
    E_OBJECT_TYPE_CHECK(bd, E_BORDER_TYPE);
-   if ((bd->fullscreen) || (bd->maximized)) return;
+   if ((bd->fullscreen) || (bd->maximized) || (bd->shading)) return;
    if (bd->shaded)
      {
 //	printf("UNSHADE!\n");