dan sinclair <[EMAIL PROTECTED]> writes: >> ack! this doesn't apply anymore because now the dialog calls have >> changed. i see what you mean and we shoudl move more dialogs into >> core code over time though :) > > I changed this a bit yesterday, the text string is still in each > module, but I've made them all the same so (I think) you should only > need to translate it once.
Yes I saw your changes -- they help a lot. But I think that moving the tests and the text strings out of each module would be better by cutting down on the code duplication. > The dialog titles could probably be changed in the same fashion to > cut down on their translation too. In my patch I just used the label field in the E_Module struct. Every module did that anyway. -- Martin Geisler GnuPG Key: 0x7E45DD38 PHP EXIF Library | PHP Weather | PHP Shell http://pel.sf.net/ | http://phpweather.net/ | http://mgeisler.net/ Read/write EXIF data | Show current weather | A shell in a browser
pgpfiYCjLXdR3.pgp
Description: PGP signature
