Nathan Ingersoll wrote:
Nice improvements.
On 12/3/05, Morten Nilsen <[EMAIL PROTECTED]> wrote:
+ e = __ecore_config_bundle_local->data;
+
+ do {
+ ecore_sheap_insert(keys, e->key);
+ } while((e = e->next));
Is this loop making a safe assumption that __ecore_config_bundle_local and
__ecore_config_bundle_local->data are not NULL?
AFAICT, __ecore_config_bundle_local would only be NULL if
ecore_config_init failed.. same goes for the first data pointer.
would probably be a good idea to check the return of ecore_config_init..
I hadn't considered that, as the original code doesn't check it..
--
Morten
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
