In the engrave sources, file: src/lib/engrave_out.c at about line 150
(current CVS) the last parameter should be surrounded by "", like this:

snprintf(cmd, sizeof(cmd), "edje_cc -v %s %s %s \"%s\"",

Also all strings passed to the system() call should be audited for the
same problem in e_utils/src/bin/e17setroot/e17setroot.c

This bug prevents setting file as background images that have in their
names non alphanumeric characters.

That was the important bit, what follows are some minor considerations.

I've been working on the problem 'set a random background image
selected from a huge (>3000) collection of JPEGs'.
In this scenario keeping a copy of all the images in the .e directory is
not really a good idea since it should be kept in sync and eat some
large amount of disk space for nothing.

Working to find a solution I found out that e17 ignores a background
change request from e_lib_background_set() if the filename did not
change across different calls. Example:

$ cp someimage.jpg /tmp/bg.jpg
$ e17setroot /tmp/bg.jpg        <-- e17 updates the bg
$ cp someotherimage.jpg /tmp/bg.jpg
$ e17setroot /tmp/bg.jpg        <-- e17 does nothing

This is probably not a big issue, but it is annoying. It tries to be
smart and fails.

For now I remove the edje file just after calling e17setroot, e17 is
happy since the file will not be really unlinked until it is open by some
process. An additional call to my script takes care of startup, thanks
to e17 sane defaults.

This way the script is simple, doesn't keep any state and can be called
by cron. Another way was to write a real daemon that would remove the
old edje file after setting a new image, or write the state to some
private file, but that was overkill.

Thanks.

P.S.
Please CC me, since I'm not subscribed to the list.

--
Daniele Venzano
http://www.brownhat.org


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to