On Mon, 9 Jan 2006 14:49:46 +0000 Aleksej Struk <[EMAIL PROTECTED]> babbled:
> Hi all, ok- i've been going over the patch - and the e.smart-maximize.patch is a patch containing cvs conflicts like: +<<<<<<< e_maximize.c +static int _e_mzone_split( Evas_List **add_splits_to, struct _m_zone *mzone, E_Gadman_Client *gmc ); + +int _e_mzone_cb_square_reverse_sort( void *e1, void *e2 ); +int _e_mzone_cb_width_reverse_sort( void *e1, void *e2 ); +int _e_mzone_cb_height_reverse_sort( void *e1, void *e2 ); + +void +e_maximize_border_gadman_fit( E_Border *bd, int *x1, int *y1, int *x2, int *y2 ) +======= EAPI void e_maximize_border_gadman_fit(E_Border *bd, int *x1, int *y1, int *x2, int *y2) +>>>>>>> 1.5 - i think you need to resolve your conflicts with a cvs update before you make the patch - figuring out what you mean is a lot of work - by reading a patch that has conflicts that need resolving. there's more than 1. :( secondly - style-wise. can you just makie a small style change so i dont have to do it all over instead of func( blah, blah2 ); do: func(blah, blah2); :) > Some weeks ago it was a conversation about how e17 does smart > maximization of a window. > It was proposed to introduce some user defined configuration options, > to let e17 to know the area of the desktop > it can use for maximization. However, I think, Rasterman proposed > much better solution. The idea was, that each gadget > should hint if it allows to maximize over it. > > Please find the *.tar.gz archive attached. Also this archive can be > found via the following link : > http://rose.inf.unibz.it/~struk/e17/e.patch.tar.gz. > This archive contains some patches to e and e_modules. > > First it touches e itself. It introduces > E_GADMAN_POLICY_ALLOW_OVERLAP flag. This flag can be used to set the > way gadget influences the maximization of a border. Second, it patches > all the standard E modules ( battery, cpufreq, start, etc ) and > introduces a configuration menu option which allows to set > E_GADMAN_POLICY_ALLOW_OVERLAP flag. > > If E_GADMAN_POLICY_ALLOW_OVERLAP flag is set for the gadget, then the > gadget is not taken into account when the maximized border computed. > And vice versa, if it is not set > the gadget is taken into account computing maximized border. The > following code shows how this option can be set/unset: > > E_Gadman_Policy pol; > ... > pol = .... ; > > if( gadget->conf->allow_overlap == 0 ) > pol &= ~E_GADMAN_POLICY_ALLOW_OVERLAP; > else > pol |= E_GADMAN_POLICY_ALLOW_OVERLAP; > > e_gadman_client_policy_set( face->gmc, pol ); > ... > > Please refer to the modules code, after applying the patch, to see > how things really works ::)) > > Furthermore, the archive contains two files : e_mod_config.c and > e_mod_config.h for the > start module. This two files implements the configuration dialog of > the start module. > > Finally, the archive contains some patches for extra modules in > e_modules. The 'calendar' and the 'monitor' modules are > patched to support the mechanizm described above. > > As a conclusion, I think, this patch partialy solves the 4th case of > the maximization TODO. > > Thanks > Aleksej > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [EMAIL PROTECTED] 裸好多 Tokyo, Japan (東京 日本) ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
