On Wednesday, 01 February 2006, at 22:05:57 (-0500),
Kris Maglione wrote:
> +/* XXX:
> + * This should probably be done another way, but this way
> + * is better than leaving the chance of a non-terminated
> + * string (which has afflicted me once already) */
> +#define snprintf(str, size, format, ...) do { \
> + snprintf(str, size, format, ##__VA_ARGS__); \
> + (str)[size-1] = 0; \
> + } \
> + while (0)
Negative. This is not portable.
> -#ifdef HAVE_PAM
> - if (e->config->auth == ENTRANCE_USE_PAM)
> + if (HAVE_PAM && e->config->auth == ENTRANCE_USE_PAM)
This is horrible. Compile-time directives masquerading as run-time
conditionals is just evil.
Michael
--
Michael Jennings (a.k.a. KainX) http://www.kainx.org/ <[EMAIL PROTECTED]>
n + 1, Inc., http://www.nplus1.net/ Author, Eterm (www.eterm.org)
-----------------------------------------------------------------------
"Follow me; everything is alright. I'll be the one to tuck you in at
night. And if you want to leave, I can guarantee you won't find
nobody else like me." -- Uncle Kracker, "Follow Me"
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
