Sthithaprajna Garapaty wrote:
Hey.. you weren't supposed to touch that! But I guess now I can make it
public.
:)
whipped up a patch just now, that gets rid of the warnings, and one
superfluous pointer.. there might be more pointers that can be
discarded, but I just did a cursory glance of the code :)
--
Cheers,
Morten
:wq
diff -ur taskbar-0.0.2/e_mod_main.c taskbar-0.0.2-mn/e_mod_main.c
--- taskbar-0.0.2/e_mod_main.c 2006-05-29 06:47:28.000000000 +0200
+++ taskbar-0.0.2-mn/e_mod_main.c 2006-05-29 18:57:23.249731143 +0200
@@ -13,7 +13,7 @@
static char *_gc_label(void);
static Evas_Object *_gc_icon(Evas *evas);
/* and actually define the gadcon class that this module provides (just 1) */
-static const E_Gadcon_Client_Class _gadcon_class =
+static E_Gadcon_Client_Class _gadcon_class =
{
GADCON_CLIENT_CLASS_VERSION,
"taskbar",
@@ -127,7 +127,6 @@
Evas_Coord x, y, w, h;
int cx, cy, cw, ch;
const char *drop[] = { "enlightenment/border" };
- Evas_List *l;
inst = E_NEW(Instance, 1);
@@ -238,7 +237,6 @@
_taskbar_new(Evas *evas, E_Zone *zone)
{
Taskbar *b;
- char buf[4096];
b = E_NEW(Taskbar, 1);
b->o_box = e_box_add(evas);
@@ -276,7 +274,6 @@
if (!taskbar_config->menu)
{
E_Menu *mn;
- E_Menu_Item *mi;
int cx, cy, cw, ch;
mn = e_menu_new();
@@ -485,8 +482,6 @@
static void
_taskbar_icon_free(Taskbar_Icon *ic)
{
- Evas_Object *o;
-
if (taskbar_config->menu)
{
e_menu_post_deactivate_callback_set(taskbar_config->menu, NULL, NULL);
@@ -563,10 +558,7 @@
static int
_taskbar_cb_timer_drop_recalc(void *data)
{
- Instance *inst;
-
- inst = data;
- _taskbar_instance_drop_zone_recalc(inst);
+ _taskbar_instance_drop_zone_recalc((Instance *)data);
return 1;
}
@@ -575,7 +567,7 @@
{
Instance *inst;
- inst = data;
+ inst = (Instance *)data;
_taskbar_resize_handle(inst->taskbar);
_taskbar_instance_drop_zone_recalc(inst);
}
@@ -633,7 +625,6 @@
if (evas_key_modifier_is_set(ev->modifiers, "Alt")) {
E_Menu *mn;
- E_Menu_Item *mi;
mn = e_menu_new();
e_menu_post_deactivate_callback_set(mn, _taskbar_cb_menu_post, NULL);
@@ -1128,9 +1119,6 @@
b = _taskbar_zone_find(bd->zone);
if (!b) return 1;
-
- Evas_List *l;
-
if (ev->border->desk == e_desk_current_get(ev->border->zone)) {
ic = _taskbar_icon_find(b, bd);
if (ic) return 1;
@@ -1153,6 +1141,7 @@
_taskbar_resize_handle(b);
_gc_orient(b->inst->gcc);
}
+ return 0;
}
static int
@@ -1280,7 +1269,7 @@
(E_EVENT_BORDER_STICK, _taskbar_cb_event_border_zone_set, NULL));
*/
e_gadcon_provider_register(&_gadcon_class);
- return 1;
+ return (void *)1;
}
EAPI int
