On Tue, Oct 17, 2017 at 2:39 AM, Amitesh Singh <amitesh...@samsung.com> wrote: > > ami pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=329dcfccd79e6b31657c60bdacf797c7d2c8f0d3 > > commit 329dcfccd79e6b31657c60bdacf797c7d2c8f0d3 > Author: Amitesh Singh <amitesh...@samsung.com> > Date: Tue Oct 17 13:37:26 2017 +0900 > > efl_ui_format: fix the namings and docs > > it is based on review comments by Gustavo and JP. > --- > src/lib/efl/interfaces/efl_ui_format.eo | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/src/lib/efl/interfaces/efl_ui_format.eo > b/src/lib/efl/interfaces/efl_ui_format.eo > index 74d6249127..a140135ec1 100644 > --- a/src/lib/efl/interfaces/efl_ui_format.eo > +++ b/src/lib/efl/interfaces/efl_ui_format.eo > @@ -3,8 +3,8 @@ import eina_types; > function Efl.Ui.Format_Func_Cb { > [[Function pointer for format function hook]] > params { > - @in str: ptr(Eina.Strbuf); > - @in value: Eina.Value; > + @out str: Eina.Strbuf; [[the formated string to be appended by user.]] > + @in value: const(any_value); [[The Eina.Value passed by $obj.]]
what about passing the extra parameter format_string? > } > }; > > @@ -12,16 +12,16 @@ interface Efl.Ui.Format > { > [[interface class for format_func]] > methods { > - @property func_cb @protected { > + @property format_cb @protected { > set { > - [[Set the format function pointer to format the indicator string. > + [[Set the format function pointer to format the string. > ]] > } > values { > func: Efl.Ui.Format_Func_Cb @nullable; [[The format function > callback]] > } > } > - @property unit @protected { > + @property format_string @protected { > [[Control the format string for a given units label here would remove "units label", write a more generic term. -- Gustavo Sverzut Barbieri -------------------------------------- Mobile: +55 (16) 99354-9890 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel