On Wed, 01 Nov 2017 01:41:08 +0000 Mike Blumenkrantz <michael.blumenkra...@gmail.com> said:
> Assuming you are looking at the Enlightenment internal menu code, that is. > If you are looking at the async efreet code, this has never successfully > been used and is not currently used anywhere that I am aware of. netstar did some patching of efreet and added some locks... and the problems seen with everything went away it seems. this is a red flag i think... so worth looking into. specifically the patch he pasted here: https://phab.enlightenment.org/T6084 that screams to me right now that someone, somewhere is calling efreet from threads. and it seems to only be affecting e... so e or some module shipped with e... i need to hunt a bit. it may has been related to menu too so i was wondering... and indeed at least: _scan_mime_func() in evry_plug_files.c which is a thread func.... calls efreet_mime_type_get() but this isn't related to menus though... :/ so i'm a bit baffled atm. i was going to add mainloop is call checks through efreet's api calls and barf if something is not called from mainloop. > On Tue, Oct 31, 2017 at 9:20 PM Mike Blumenkrantz < > michael.blumenkra...@gmail.com> wrote: > > > There are no threads in the menu code that you are looking at, only > > functions with names from a time when there was an attempt to make efreet > > menu parsing asynchronous. > > > > On Tue, Oct 31, 2017 at 8:56 PM Carsten Haitzler <ras...@rasterman.com> > > wrote: > > > >> On Tue, 31 Oct 2017 15:31:08 +0000 Mike Blumenkrantz > >> <michael.blumenkra...@gmail.com> said: > >> > >> > After reviewing the currently reported issues I'm now planning to do the > >> > final release on Thursday. If anyone is working on any last minute bug > >> > fixes, please have them tested and committed by then. > >> > >> can you hold off on this until i look at the apps menu stuff? i juast am > >> spotting it's using threads... and threads + efreet == bad. netstar just > >> pointed this out to me (as throwing in locks into efreet seems to fix > >> things > >> for him). > >> > >> i suspect i need to review this and undo the threading if it's also doing > >> efreet calls from there. > >> > >> -- > >> ------------- Codito, ergo sum - "I code, therefore I am" -------------- > >> Carsten Haitzler - ras...@rasterman.com > >> > >> > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- Carsten Haitzler - ras...@rasterman.com ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
