Hi, In addition to the above if 2) is the desired approach would there be any opposition to changing eina_str_join and eina_str_join_static (and potentially eina_str_join_len even) to be variadic?
Thanks, Andy On Thu, 16 Nov 2017 at 10:56 Andrew Williams <a...@andywilliams.me> wrote: > Hi. > > Looking at eina_str and I see handy split and join methods. > Split returns an array but join accepts only two strings to join. > This feels unbalanced and I wonder what people feel about this. Most libs > seem to balance it by passing an array to join(). > > Looking through efl it seems that neither str_join or str_join_static are > used (str_join_len is used in file_join but it's understanable that passing > lengths as well makes an array less attractive). > > I have two potential proposals: > 1) to change the signature of eina_str_join (and eina_str_join_static) to > pass an array > 2) add eina_str_join_array and eina_str_join_static_array that perform the > expected operation. > > Any thoughts from the team? > Andy > -- > http://andywilliams.me > http://ajwillia.ms > -- http://andywilliams.me http://ajwillia.ms ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
