Hello Cedric.
On 05/02/2018 07:46 PM, Cedric BAIL wrote: > cedric pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=9c23ffb675316d982d3b9442cb771f31dc1cc0ed > > commit 9c23ffb675316d982d3b9442cb771f31dc1cc0ed > Author: Cedric Bail <[email protected]> > Date: Wed May 2 09:35:57 2018 -0700 > > Revert "edje_cc: fix default color_class colors" > > This reverts commit d83ebb69808abdd067aa88dfeb7cd5a8216a9d90. > > Had to revert this as it break backward compatibility with what theme > expect to be the default value. We could reintroduce this with a version > check if necessary. > > T6885 Did you made Andrii aware of this revert?I think this is something we should aim for. Making the original author aware will give her/him a chance to come up with a better solution instead of having to spent time to find out why its broken again. I think the revert is fine in this case. Not picking on you, it was just the first revert I saw after thinking on this a bit more. regards Stefan Schmidt ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
