Hello. Sorry for the errors.. The following commits fix the errors and they have been submitted to the upstream master. bce7e7d0d7cd543f0905d1b15bde3de580f4e8e4 19833657e81734ac0b9d4bd9ffcca0dddfe21867 I will keep in mind your advice. Thank you. Best Regards, Jaehyun Cho. -----Original Message----- From: "Stefan Schmidt"<ste...@datenfreihafen.org> To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; "Hosang Kim"<hosang12....@samsung.com>; "Jaehyun Cho"<jae_hyun....@samsung.com>; Cc: Sent: 2018-05-15 (화) 17:28:52 Subject: Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_ui_slider: refactor slider widget. Hello.
On 15.05.2018 07:21, Hosang Kim wrote: > jaehyun pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=5db61e4d64f684a8eaf4b75ebceb18d8708ac8d5 > > commit 5db61e4d64f684a8eaf4b75ebceb18d8708ac8d5 > Author: Hosang Kim <hosang12....@samsung.com> > Date: Tue May 15 14:16:00 2018 +0900 > > efl_ui_slider: refactor slider widget. > > Test Plan: elementary_test -> Efl.Ui.Slider, Efl.Ui.Slider_Interval, > slider > > Reviewers: woohyun, cedric, Jaehyun_Cho > > Reviewed By: Jaehyun_Cho > > Subscribers: zmike, cedric > > Tags: #efl > > Differential Revision: https://phab.enlightenment.org/D5908 This patch breaks various things at once. Please have a look quickly or we have to revert it and wait for a version that does not break things. The breaks I have seen so far are: 1) Broken examples build in the cxx examples: https://travis-ci.org/Enlightenment/efl/jobs/379061148 slider_cxx_example.cc: In function 'void efl_main(void*, const Efl_Event*)': slider_cxx_example.cc:29:8: error: 'struct efl::ui::Slider' has no member named 'text_set'; did you mean 'theme_set'? sl2.text_set("Counter"); ^~~~~~~~ theme_set slider_cxx_example.cc:52:8: error: 'struct efl::ui::Slider' has no member named 'format_string_set' sl4.format_string_set("%1.0f units"); ^~~~~~~~~~~~~~~~~ slider_cxx_example.cc:58:8: error: 'struct efl::ui::Slider' has no member named 'indicator'; did you mean 'Animator'? sl5.indicator().format_string_set("%1.0f rabbit(s)"); ^~~~~~~~~ Animator slider_cxx_example.cc:80:8: error: 'struct efl::ui::Slider' has no member named 'format_cb_set'; did you mean 'map_uv_set'? sl6.format_cb_set(format_cb); ^~~~~~~~~~~~~ map_uv_set slider_cxx_example.cc:86:8: error: 'struct efl::ui::Slider' has no member named 'format_string_set' sl7.format_string_set("%1.3f units"); ^~~~~~~~~~~~~~~~~ 2) The elm test suite fails in elm_slider_legacy: 50%: Checks: 2, Failures: 1, Errors: 0 tests/elementary/elm_test_slider.c:20:F:elm_slider:elm_slider_legacy_type_check:0: Assertion '!strcmp(type, "Elm_Slider")' failed I would the author as well as the reviewer/committer to run the test suite with such a big re-factor change. Having the cxx bindings disabled locally for you is also not the best idea when testing things. regards Stefan Schmidt ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
