Hello. On 24.07.2018 16:07, Mike Blumenkrantz wrote: > Regarding the edje function: > > https://phab.enlightenment.org/D4403 > > It looks like the function prototype was just removed during this > conversion and then never added back?
Good point. Conrad, could you shed some light one what happened to edje_object_color_class_description_get ? We are looking into API breaks for the 1.21 release and wonder what happened with this function. regards Stefan Schmidt > On Tue, Jul 24, 2018 at 5:28 AM Stefan Schmidt <ste...@datenfreihafen.org> > wrote: > >> Hello. >> >> On 24.07.2018 10:46, Stefan Schmidt wrote: >>> Hello. >>> >>> One of the big missing steps towards a 1.21 release is to make sure we >>> are not breaking ABI or API from older releases. If you want to help >>> with the release please spare an hour and look over the report from ABI >>> Laboratory and help to identify if we have any breaks not related to our >>> beta APIs. >>> >>> >> https://abi-laboratory.pro/index.php?view=objects_report&l=efl&v1=1.20.7&v2=1.21.0-alpha1 >> >> My personal review is below. I ignored all beta and EO APIs here. >> >> Added: >> Ecore_Common.h, libecore.so.1.21.0 >> ecore_init_ex ( int argc, char** argv ) >> ecore_shutdown_ex ( ) >> >> I think the names are not descriptive at all. What should the _ex stand >> for here? The API description speaks about propagating events on the >> main loop after init and callback setup. >> >> >> Removed: >> edje_object.eo.legacy.h, libedje.so.1.20.7 >> edje_object_color_class_description_get ( Edje_Object const* obj, char >> const* color_class ) >> >> It could be argued that it was part of the edje_onject, but it was >> exposed as legacy API none the less? I still can find an EAPI definition >> in edje_util.c for it. Would be great if someone could shed some light >> on this one. >> >> regards >> Stefan Schmidt >> >> >> ------------------------------------------------------------------------------ >> Check out the vibrant tech community on one of the world's most >> engaging tech sites, Slashdot.org! http://sdm.link/slashdot >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
