On Fri, Jul 21, 2006 at 07:01:01PM +0100, Essien Ita Essien wrote: > > >>I know I said before that I'd take a look at them, and I know I did and > >>they looked good for the most part. Somehow I got distracted and never > >>got them committed. I remember thinking the two functions for getting > >>the geometries could be combined into a single one (since they were > >>almost duplicate, and were called in succession iirc). > >> > >> > >Yeah, that was my original intent, but i thought it an overkill to > >return a geometry struct, or returning values via passed in pointers > >(doesn't feel too natural) or even a two int array (like pipe() does). > > > >>rephorm > >> > okie dokie. this modified patch follows rephorms suggestion, so the > geometry parsing is now:
<snip> Looks good. See the commit logs for a small note (not your fault). Good stuff :) -- rephorm ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
