On Mon, 14 Jan 2019 13:28:57 -0500 Mike Blumenkrantz <[email protected]> said:
sorry about that - i think this must have crept in with other fixes i also was doing at the time. i had a whole slew of things i was fixing that were irritating or causing bugs, and some valgrind complaints in the process etc. > Hi, > > Thanks for taking the time to do a bit of cleanup here; we've had these > warnings in tree for quite some time! > > While it's certainly helpful to fix compiler warnings, it may be worth > considering taking the time to merge similar patches (e.g., combine 20+ > 'warn - make buffer bigger to avoid trunc warn' patches into a single > patch) in order to make them easier to review/read in history and also > avoid cases such as this one where the commit log does not reflect the > content of the patch. > > Regards, > Mike > > On Fri, Jan 11, 2019 at 8:57 PM Carsten Haitzler <[email protected]> > wrote: > > > raster pushed a commit to branch master. > > > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=920d9e57b0415ed2737fb048be06e8225c770037 > > > > commit 920d9e57b0415ed2737fb048be06e8225c770037 > > Author: Carsten Haitzler (Rasterman) <[email protected]> > > Date: Fri Jan 11 11:58:26 2019 +0000 > > > > warn - make buffer bigger to avoid trunc warn > > --- > > src/bin/e_gadget_runner.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/bin/e_gadget_runner.c b/src/bin/e_gadget_runner.c > > index 1d98f133c..30a9b7c02 100644 > > --- a/src/bin/e_gadget_runner.c > > +++ b/src/bin/e_gadget_runner.c > > @@ -725,7 +725,7 @@ popup_added(void *data, Evas_Object *obj EINA_UNUSED, > > void *event_info) > > if (event_info == efl_wl_extracted_surface_object_find(surface)) > > { > > Evas_Object *base = > > efl_wl_extracted_surface_extracted_parent_get(event_info); > > - Tooltip *tt; > > + Tooltip *tt = NULL; > > > > //FIXME: if (inst->tooltip_content) error > > if (base) > > > > -- > > > > > > > > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- Carsten Haitzler - [email protected] _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
