Hi, It's been a week with no opposition so it seems fine for this to be merged.
Mike On Sat, Mar 23, 2019 at 5:56 AM Carsten Haitzler <ras...@rasterman.com> wrote: > On Tue, 19 Mar 2019 10:34:15 -0400 Christopher Michael < > devilho...@comcast.net> > said: > > > Hi All, > > > > Output rotation has been broken (when using the drm engines) for a > > little while now. I have fixes for both software & hardware engines > > (drm and gl_drm) all ready to go on > > [1]https://phab.enlightenment.org/T7690. Some of these patches have > > already been reviewed & accepted, others are still pending review. > > YAY! well done dh! > > > In my opinion, it would be really nice to get this fixes reviewed, > > accepted and pushed before the release goes out. There is however one > > point of contention ... [2]https://phab.enlightenment.org/D8114 ... > > This patch adds One new API inside ecore_drm2 that Enlightenment needs > > in order to make output rotation functional. It is a small code > > addition that should not affect anything else in the release, however > > it IS a new API addition. > > > > Basically, I am wondering if we can get these patches reviewed and > > pushed, and perhaps a small exception for the API addition, before > > release ?? I realize that we are not supposed to add new API when we > > are frozen, but I am asking for a small exception in this case.. > > It was pretty clear years ago - a bugfix that requires an API change (that > doesn't break previous stable APIs in prior releases) is OK as it's > necessary > for that fix. As long as it's necessary. :) > > > Thoughts ?? > > > > dh > > > > References > > > > 1. https://phab.enlightenment.org/T7690 > > 2. https://phab.enlightenment.org/D8114 > > > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > Carsten Haitzler - ras...@rasterman.com > > > > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
