[EGIT] [core/enlightenment] master 01/01: error messages - let's be less ramatic and have fewer of these on start

[Carsten Haitzler]

raster pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=6af9d75293b9bcbbb6d575c9dc37ac040e25a8ec

commit 6af9d75293b9bcbbb6d575c9dc37ac040e25a8ec
Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
Date:   Tue Jun 4 14:14:18 2019 +0100

    error messages - let's be less ramatic and have fewer of these on start
    
    various errors we have are not actual errors but mostly information or
    debug or status messages, so don't use ERR or just don't do the thing
    that triggers it as it's useless. This leads to a less
    noisy/error-like start output. cleaner for a release for sure.
---
 src/bin/e_comp_wl.c         | 4 ++--
 src/bin/e_comp_x.c          | 2 +-
 src/modules/bluez5/bz_obj.c | 6 ++++--
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/bin/e_comp_wl.c b/src/bin/e_comp_wl.c
index e56e4e6f8..566576d6c 100644
--- a/src/bin/e_comp_wl.c
+++ b/src/bin/e_comp_wl.c
@@ -3006,7 +3006,7 @@ e_comp_wl_init(void)
    /* try to init ecore_wayland */
    if (!ecore_wl2_init())
      {
-        e_error_message_show(_("Enlightenment cannot initialize 
Ecore_Wl2!\n"));
+        fprintf(stderr, _("Enlightenment cannot initialize Wayland client 
connection.\n"));
         return EINA_FALSE;
      }
 
@@ -3021,7 +3021,7 @@ e_comp_wl_init(void)
    /* try to create a wayland compositor */
    if (!_e_comp_wl_compositor_create())
      {
-        e_error_message_show(_("Enlightenment cannot create a Wayland 
Compositor!\n"));
+        fprintf(stderr, _("Enlightenment cannot create a Wayland 
Compositor.\n"));
         return EINA_FALSE;
      }
 
diff --git a/src/bin/e_comp_x.c b/src/bin/e_comp_x.c
index 37a631e53..0835ee912 100644
--- a/src/bin/e_comp_x.c
+++ b/src/bin/e_comp_x.c
@@ -5813,7 +5813,7 @@ e_comp_x_init(void)
    Eina_List *h = NULL;
    if (!ecore_x_init(NULL))
      {
-        e_error_message_show(_("Enlightenment cannot initialize Ecore_X!\n"));
+        fprintf(stderr, _("Enlightenment cannot initialize X 
Connection...\n"));
         return EINA_FALSE;
      }
 
diff --git a/src/modules/bluez5/bz_obj.c b/src/modules/bluez5/bz_obj.c
index dc6aaf132..f9515d4c7 100644
--- a/src/modules/bluez5/bz_obj.c
+++ b/src/modules/bluez5/bz_obj.c
@@ -346,8 +346,10 @@ bz_obj_add(const char *path)
                                                              
"PropertiesChanged",
                                                              
cb_obj_prop_changed, o);
              // disable the filter for discovery later
-             eldbus_proxy_call
-               (o->proxy, "SetDiscoveryFilter", cb_obj_discovery_filter, o, 
-1, "");
+             // XXX: this doesnt seem to exist on the bluez daemons i see
+             // so don't do this to avoid error noise and it's useless it seems
+             // eldbus_proxy_call
+             //  (o->proxy, "SetDiscoveryFilter", cb_obj_discovery_filter, o, 
-1, "");
           }
         goto done;
      }

--