zmike pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=d5bf69ff53f5e9268663f0dd3d16ac79113217a0
commit d5bf69ff53f5e9268663f0dd3d16ac79113217a0 Author: Marcel Hollerbach <[email protected]> Date: Wed Sep 11 13:38:13 2019 -0400 efl_ui_group_item: fix insertion of item at the end Summary: in this case here, eina list count already returns the count *including* the subobject, the case in pack_at below (where also +1 is added) is different to that, as count is the value *before* the list add. Depends on D9870 Reviewers: segfaultxavi, zmike, cedric Reviewed By: zmike Subscribers: #reviewers, #committers Tags: #efl Differential Revision: https://phab.enlightenment.org/D9871 --- src/lib/elementary/efl_ui_group_item.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/efl_ui_group_item.c b/src/lib/elementary/efl_ui_group_item.c index 9c3c03a9a9..5dd3a6bafe 100644 --- a/src/lib/elementary/efl_ui_group_item.c +++ b/src/lib/elementary/efl_ui_group_item.c @@ -128,7 +128,7 @@ _efl_ui_group_item_efl_pack_linear_pack_end(Eo *obj, Efl_Ui_Group_Item_Data *pd, int group_index = efl_pack_index_get(container, obj); _register_item(obj, pd, subobj); - HANDLE_REG_CALL(efl_pack_at(container, subobj, group_index + eina_list_count(pd->registered_items) + 1)); + HANDLE_REG_CALL(efl_pack_at(container, subobj, group_index + eina_list_count(pd->registered_items))); } EOLIAN static Eina_Bool --
