zmike pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=167e3c4c298dd2b16735805fba1f78c40a2962a1
commit 167e3c4c298dd2b16735805fba1f78c40a2962a1
Author: JunsuChoi <jsuya.c...@samsung.com>
Date: Thu Aug 22 07:15:30 2019 -0400
edje_cc: Fix always true condition.
Summary:
The condition at 742 line is always true. So I fix it.
If action is not ACTION_STOP or ACTION_TYPE_SCRIPT, go to continue.
Test Plan: N/A
Reviewers: bu5hm4n, Hermet, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, kimcinoo, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9667
---
src/bin/edje/edje_cc_out.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/bin/edje/edje_cc_out.c b/src/bin/edje/edje_cc_out.c
index 2b5f700e3e..f932eac9e9 100644
--- a/src/bin/edje/edje_cc_out.c
+++ b/src/bin/edje/edje_cc_out.c
@@ -736,10 +736,10 @@ check_program(Edje_Part_Collection *pc, Edje_Program *ep,
Eet_File *ef)
/*
* we are accessing part with an id,
- * if actions is ACTION_STOP or ACTION_TYPE_SCRIPT, then id is from
the parts array.
+ * if actions is ACTION_STOP or ACTION_TYPE_SCRIPT, then id is NOT
from the parts array.
* In order to not crash here, we should continue here.
*/
- if (ep->action != EDJE_ACTION_TYPE_ACTION_STOP || ep->action !=
EDJE_ACTION_TYPE_SCRIPT)
+ if (ep->action == EDJE_ACTION_TYPE_ACTION_STOP || ep->action ==
EDJE_ACTION_TYPE_SCRIPT)
continue;
if (et->id >= (int) pc->parts_count)
--
