[EGIT] [core/efl] master 04/04: elementary_codegen: check before use to avoid use after free

[Stefan Schmidt]

stefan pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=a819a954bfa005f77b296fddf9de4bfd59f9486f

commit a819a954bfa005f77b296fddf9de4bfd59f9486f
Author: Stefan Schmidt <s.schm...@samsung.com>
Date:   Fri Sep 20 12:11:39 2019 +0200

    elementary_codegen: check before use to avoid use after free
    
    These might or might not have been freed already, depending on the
    breaks form the above loop. Before we are having a use after free here
    better check on it before free'ing another time.
    
    Coverity IDs: 1402671, 1402701
    
    Reviewed-by: Mike Blumenkrantz <michael.blumenkra...@gmail.com>
    Differential Revision: https://phab.enlightenment.org/D10047
---
 src/bin/elementary/elementary_codegen.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/bin/elementary/elementary_codegen.c 
b/src/bin/elementary/elementary_codegen.c
index 2f8324f448..28ed576f25 100644
--- a/src/bin/elementary/elementary_codegen.c
+++ b/src/bin/elementary/elementary_codegen.c
@@ -701,9 +701,13 @@ _programs_parse(Evas_Object *ed)
           }
 
         edje_edit_string_free(description);
+        description = NULL;
         edje_edit_string_free(sig);
+        sig = NULL;
         edje_edit_string_free(source);
+        source = NULL;
         free(apiname);
+        apiname = NULL;
      }
 
    edje_edit_string_list_free(programs);

--