zmike pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=3b161da0ceb62e606a3cbcc98b5e16c78253a84c

commit 3b161da0ceb62e606a3cbcc98b5e16c78253a84c
Author: Mike Blumenkrantz <zm...@samsung.com>
Date:   Fri Oct 18 13:28:41 2019 -0400

    evas/language: #ifdef guard variable which is only used inside #ifdef
    
    Summary:
    this variable is already only changed inside an #ifdef, so declare and
    free it only inside the same ifdef for clarity
    
    ref 9d9aa8b6ae0c07ebe23e1ea3fcb81f8050311651
    CID 1400807
    
    Reviewers: devilhorns
    
    Reviewed By: devilhorns
    
    Subscribers: cedric, #reviewers, #committers
    
    Tags: #efl
    
    Differential Revision: https://phab.enlightenment.org/D10389
---
 src/lib/evas/common/language/evas_bidi_utils.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/lib/evas/common/language/evas_bidi_utils.c 
b/src/lib/evas/common/language/evas_bidi_utils.c
index c8360643a2..ab1afeb1f7 100644
--- a/src/lib/evas/common/language/evas_bidi_utils.c
+++ b/src/lib/evas/common/language/evas_bidi_utils.c
@@ -446,7 +446,10 @@ Eina_Bool
 evas_bidi_props_reorder_line(Eina_Unicode *eina_ustr, size_t start, size_t 
len, const Evas_BiDi_Paragraph_Props *props, EvasBiDiStrIndex **_v_to_l)
 {
    EvasBiDiStrIndex *v_to_l = NULL;
-   FriBidiChar *ustr = NULL, *base_ustr = NULL;
+   FriBidiChar *ustr = NULL;
+#ifdef EVAS_FRIBIDI_EINA_UNICODE_UNEQUAL
+   FriBidiChar *base_ustr = NULL;
+#endif
 
    if (!props)
      return EINA_FALSE;
@@ -502,7 +505,9 @@ evas_bidi_props_reorder_line(Eina_Unicode *eina_ustr, 
size_t start, size_t len,
    return EINA_FALSE;
 /* ERROR HANDLING */
 error:
+#ifdef EVAS_FRIBIDI_EINA_UNICODE_UNEQUAL
    if (base_ustr) free(base_ustr);
+#endif
    _SAFE_FREE(v_to_l);
    return EINA_TRUE;
 }

-- 


Reply via email to