This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch master
in repository evisum.

View the commit online.

commit e035f7371cb3dd7f0699ea35ff89e9e6c749b564
Author: Alastair Poole <m...@alastairpoole.com>
AuthorDate: Thu Mar 20 22:11:06 2025 +0000

    process_list: always show scroller.
    
    This annoyed some people. Make the field large enough irrespective.
---
 NEWS                         |  2 ++
 src/bin/evisum_config.c      |  2 --
 src/bin/evisum_config.h      |  3 +--
 src/bin/ui/evisum_ui.c       | 23 -----------------------
 src/bin/ui/ui_process_list.c |  8 +++-----
 5 files changed, 6 insertions(+), 32 deletions(-)

diff --git a/NEWS b/NEWS
index c8a1263..005367e 100644
--- a/NEWS
+++ b/NEWS
@@ -9,6 +9,8 @@ Evisum 0.6.2
   * Update meson to remove deprecated use.
   * Debugging terminal fallback fix.
   * Don't stretch process list fields unnecessarily.
+  * Remove show/hide scrollbar option.
+  * Bump up config version (will reinitialise).
 
 ============
 Evisum 0.6.1
diff --git a/src/bin/evisum_config.c b/src/bin/evisum_config.c
index 3b6cf55..19c9c09 100644
--- a/src/bin/evisum_config.c
+++ b/src/bin/evisum_config.c
@@ -44,7 +44,6 @@ config_init(void)
    EET_DATA_DESCRIPTOR_ADD_BASIC(_evisum_conf_descriptor, Evisum_Config, "proc.poll_delay", proc.poll_delay, EET_T_UCHAR);
    EET_DATA_DESCRIPTOR_ADD_BASIC(_evisum_conf_descriptor, Evisum_Config, "proc.fields", proc.fields, EET_T_INT);
    EET_DATA_DESCRIPTOR_ADD_BASIC(_evisum_conf_descriptor, Evisum_Config, "proc.show_statusbar", proc.show_statusbar, EET_T_UCHAR);
-   EET_DATA_DESCRIPTOR_ADD_BASIC(_evisum_conf_descriptor, Evisum_Config, "proc.show_scroller", proc.show_scroller, EET_T_UCHAR);
    EET_DATA_DESCRIPTOR_ADD_BASIC(_evisum_conf_descriptor, Evisum_Config, "proc.transparent", proc.transparent, EET_T_UCHAR);
    EET_DATA_DESCRIPTOR_ADD_BASIC(_evisum_conf_descriptor, Evisum_Config, "proc.alpha", proc.alpha, EET_T_UCHAR);
 
@@ -116,7 +115,6 @@ _config_init()
    cfg->version = CONFIG_VERSION;
    cfg->proc.poll_delay = 3;
    cfg->proc.show_kthreads = 0;
-   cfg->proc.show_scroller = 1;
    cfg->proc.show_statusbar = 0;
    cfg->proc.transparent = 0;
    cfg->proc.fields = 0xffffe24f;
diff --git a/src/bin/evisum_config.h b/src/bin/evisum_config.h
index 2819172..55c2d50 100644
--- a/src/bin/evisum_config.h
+++ b/src/bin/evisum_config.h
@@ -3,7 +3,7 @@
 
 #include "ui/evisum_ui.h"
 
-#define CONFIG_VERSION 0x0013
+#define CONFIG_VERSION 0x0014
 
 typedef struct _Evisum_Config
 {
@@ -28,7 +28,6 @@ typedef struct _Evisum_Config
       unsigned int  fields;
 
       Eina_Bool     show_statusbar;
-      Eina_Bool     show_scroller;
       Eina_Bool     transparent;
       unsigned char alpha;
    } proc;
diff --git a/src/bin/ui/evisum_ui.c b/src/bin/ui/evisum_ui.c
index fc54919..e231a4f 100644
--- a/src/bin/ui/evisum_ui.c
+++ b/src/bin/ui/evisum_ui.c
@@ -33,7 +33,6 @@ evisum_ui_config_save(Evisum_Ui *ui)
         if ((config()->proc.poll_delay != ui->proc.poll_delay) ||
             (config()->proc.show_kthreads != ui->proc.show_kthreads) ||
             (config()->proc.show_user != ui->proc.show_user) ||
-            (config()->proc.show_scroller != ui->proc.show_scroller) ||
             (config()->proc.show_statusbar != ui->proc.show_statusbar) ||
             (config()->proc.transparent != ui->proc.transparent) ||
             (config()->proc.alpha != ui->proc.alpha)
@@ -52,7 +51,6 @@ evisum_ui_config_save(Evisum_Ui *ui)
         config()->proc.poll_delay = ui->proc.poll_delay;
         config()->proc.show_kthreads = ui->proc.show_kthreads;
         config()->proc.show_user = ui->proc.show_user;
-        config()->proc.show_scroller = ui->proc.show_scroller;
         config()->proc.show_statusbar = ui->proc.show_statusbar;
         config()->proc.transparent = ui->proc.transparent;
         config()->proc.alpha = ui->proc.alpha;
@@ -138,7 +136,6 @@ evisum_ui_config_load(Evisum_Ui *ui)
    ui->proc.fields = config()->proc.fields;
    proc_info_kthreads_show_set(ui->proc.show_kthreads);
    ui->proc.show_user = config()->proc.show_user;
-   ui->proc.show_scroller = config()->proc.show_scroller;
    ui->proc.show_statusbar = config()->proc.show_statusbar;
    ui->proc.transparent = config()->proc.transparent;
    ui->proc.alpha = config()->proc.alpha;
@@ -349,16 +346,6 @@ _main_menu_show_threads_changed_cb(void *data EINA_UNUSED, Evas_Object *obj,
    evisum_ui_config_save(ui);
 }
 
-static void
-_main_menu_show_scroller_changed_cb(void *data EINA_UNUSED, Evas_Object *obj,
-                                    void *event_info EINA_UNUSED)
-{
-   Evisum_Ui *ui = data;
-
-   ui->proc.show_scroller = elm_check_state_get(obj);
-   evisum_ui_config_save(ui);
-}
-
 static void
 _main_menu_show_statusbar_changed_cb(void *data EINA_UNUSED, Evas_Object *obj,
                                      void *event_info EINA_UNUSED)
@@ -656,16 +643,6 @@ evisum_ui_main_menu_create(Evisum_Ui *ui, Evas_Object *parent, Evas_Object *obj)
    evas_object_size_hint_align_set(bx, FILL, FILL);
    evas_object_show(bx);
 
-   chk = elm_check_add(bx);
-   evas_object_size_hint_weight_set(chk, EXPAND, EXPAND);
-   evas_object_size_hint_align_set(chk, FILL, FILL);
-   elm_object_text_set(chk, _("Display scroll bar?"));
-   elm_check_state_set(chk, ui->proc.show_scroller);
-   evas_object_show(chk);
-   evas_object_smart_callback_add(chk, "changed",
-                                  _main_menu_show_scroller_changed_cb, ui);
-   elm_box_pack_end(bx, chk);
-
    chk = elm_check_add(bx);
    evas_object_size_hint_weight_set(chk, EXPAND, EXPAND);
    evas_object_size_hint_align_set(chk, FILL, FILL);
diff --git a/src/bin/ui/ui_process_list.c b/src/bin/ui/ui_process_list.c
index b146134..0b90b28 100644
--- a/src/bin/ui/ui_process_list.c
+++ b/src/bin/ui/ui_process_list.c
@@ -1930,9 +1930,9 @@ _content_add(Win_Data *wd, Evas_Object *parent)
             ui->proc.sort_reverse : 0),
             ui->proc.sort_type == PROC_SORT_BY_CPU_USAGE,
             wd);
-   evas_object_size_hint_weight_set(btn, 1.0, 0);
+   evas_object_size_hint_weight_set(btn, 0.0, 0);
    evas_object_size_hint_align_set(btn, FILL, FILL);
-   evas_object_size_hint_min_set(btn, ELM_SCALE_SIZE(BTN_WIDTH), 1);
+   evas_object_size_hint_min_set(btn, 1.5 * ELM_SCALE_SIZE(BTN_WIDTH), 1);
    evas_object_data_set(btn, "type", (void *) (int) PROC_SORT_BY_CPU_USAGE);
    evas_object_show(btn);
    evas_object_smart_callback_add(btn, "clicked", _btn_clicked_cb, wd);
@@ -1943,9 +1943,7 @@ _content_add(Win_Data *wd, Evas_Object *parent)
    elm_scroller_bounce_set(glist, 0, 0);
    elm_object_focus_allow_set(glist, 1);
    elm_scroller_policy_set(glist, ELM_SCROLLER_POLICY_AUTO,
-                           (ui->proc.show_scroller ?
-                            ELM_SCROLLER_POLICY_AUTO :
-                            ELM_SCROLLER_POLICY_OFF));
+                           ELM_SCROLLER_POLICY_AUTO);
    elm_genlist_multi_select_set(glist, 0);
    evas_object_size_hint_weight_set(glist, EXPAND, EXPAND);
    evas_object_size_hint_align_set(glist, FILL, FILL);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.

Reply via email to