[EGIT] [enlightenment] 26/89: tasks: defer taskbar refill on client add/remove to stabilize autoscroll

[Enlightenment Git]

This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch master
in repository enlightenment.

View the commit online.

commit 4b713a4295a757933b044dd91eface4d9fb72e34
Author: Alastair Poole <nets...@netstar.im>
AuthorDate: Fri Apr 17 22:58:48 2026 +0100

    tasks: defer taskbar refill on client add/remove to stabilize autoscroll
    
    Replace immediate refill on client add with a short deferred refill timer, and
    schedule the same deferred refill on client remove. This avoids rebuilding task
    item geometry during transient layout updates, which could leave autoscroll in a
    stuck state after adding windows.
    
    Also clean up both refill timers during module shutdown.
    
    This has taken years to fix...I'm talking years. Unreal.
---
 src/modules/tasks/e_mod_main.c | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/src/modules/tasks/e_mod_main.c b/src/modules/tasks/e_mod_main.c
index b31c22eb5..01b72e67a 100644
--- a/src/modules/tasks/e_mod_main.c
+++ b/src/modules/tasks/e_mod_main.c
@@ -62,6 +62,8 @@ static void         _tasks_free(Tasks *tasks);
 static void         _tasks_refill(Tasks *tasks);
 static void         _tasks_refill_all();
 static void         _tasks_refill_border(E_Client *ec);
+static Eina_Bool    _tasks_refill_deferred(void *data EINA_UNUSED);
+static void         _tasks_refill_deferred_schedule(void);
 
 static Tasks_Item  *_tasks_item_find(Tasks *tasks, E_Client *ec);
 static Tasks_Item  *_tasks_item_new(Tasks *tasks, E_Client *ec);
@@ -103,6 +105,7 @@ static E_Config_DD *conf_edd = NULL;
 static E_Config_DD *conf_item_edd = NULL;
 
 static Ecore_Timer *task_refill_timer;
+static Ecore_Timer *task_refill_deferred_timer;
 
 Config *tasks_config = NULL;
 
@@ -183,6 +186,8 @@ e_modapi_shutdown(E_Module *m EINA_UNUSED)
    Config_Item *cfg;
 
    e_gadcon_provider_unregister(&_gadcon_class);
+   E_FREE_FUNC(task_refill_deferred_timer, ecore_timer_del);
+   E_FREE_FUNC(task_refill_timer, ecore_timer_del);
 
    EINA_LIST_FREE(tasks_config->tasks, tasks)
      {
@@ -546,6 +551,23 @@ _tasks_refill_all(void)
      }
 }
 
+static Eina_Bool
+_tasks_refill_deferred(void *data EINA_UNUSED)
+{
+   task_refill_deferred_timer = NULL;
+   _tasks_refill_all();
+   return ECORE_CALLBACK_CANCEL;
+}
+
+static void
+_tasks_refill_deferred_schedule(void)
+{
+   if (task_refill_deferred_timer)
+     ecore_timer_loop_reset(task_refill_deferred_timer);
+   else
+     task_refill_deferred_timer = ecore_timer_loop_add(0.08, _tasks_refill_deferred, NULL);
+}
+
 static void
 _tasks_refill_border(E_Client *ec)
 {
@@ -1206,7 +1228,7 @@ _tasks_cb_event_client_add(void *data EINA_UNUSED, int type EINA_UNUSED, void *e
              tasks->clients = eina_list_append(tasks->clients, ev->ec);
           }
      }
-   _tasks_refill_all();
+   _tasks_refill_deferred_schedule();
    return EINA_TRUE;
 }
 
@@ -1216,6 +1238,7 @@ _tasks_cb_event_client_remove(void *data EINA_UNUSED, int type EINA_UNUSED, void
    E_Event_Client *ev = event;
 
    _tasks_client_remove(ev->ec);
+   _tasks_refill_deferred_schedule();
    return EINA_TRUE;
 }
 


-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.