[EGIT] [efl] 03/08: eet - spotted leak of eet file path - stringshare would have not worked

[Enlightenment Git]

This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch master
in repository efl.

View the commit online.

commit b1243276eb29e0eaf04f804cd1fc49cdfab4593d
Author: Carsten Haitzler <ras...@rasterman.com>
AuthorDate: Fri May 15 17:02:09 2026 +0100

    eet - spotted leak of eet file path - stringshare would have not worked
    
    we memset struct to zero BEFORE deleting the stringshare'd path in it!
    bad! the refcount would just keep going up, never down of any path eet
    sees!
    
    @fix
---
 src/lib/eet/eet_lib.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/lib/eet/eet_lib.c b/src/lib/eet/eet_lib.c
index 1296ca9036..a10fc6e281 100644
--- a/src/lib/eet/eet_lib.c
+++ b/src/lib/eet/eet_lib.c
@@ -1427,11 +1427,12 @@ eet_internal_close(Eet_File *ef,
         eina_file_close(ef->readfp);
      }
 
+   /* free it */
+   eina_stringshare_del(ef->path);
+
    /* zero out ram for struct - caution tactic against stale memory use */
    memset(ef, 0, sizeof(Eet_File));
 
-   /* free it */
-   eina_stringshare_del(ef->path);
    if (!shutdown)
      eet_file_mp_free(ef);
    return err;


-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.