This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch master
in repository enlightenment.
View the commit online.
commit e4b884626065ed84985de6f055089b3de89d6db2
Author: [email protected] <[email protected]>
AuthorDate: Sun Mar 15 18:47:29 2026 -0600
fix: replace elm_check with elm_icon in WiFi header to suppress hover visual
The elm_check widget shows its own internal hover/fade animation when
the mouse passes over the header row, which is jarring in a non-selectable
group header that is not meant to behave like a normal list item.
Replace it with a plain elm_icon that reflects the wireless_enabled state
(network-wireless / network-wireless-offline). Toggling is driven by a
direct EVAS_CALLBACK_MOUSE_UP on the icon, which has no hover chrome of
its own. evas_object_propagate_events_set(EINA_FALSE) is retained so the
surrounding genlist row still does not process the click.
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
---
src/modules/networkmanager/e_mod_main.c | 35 +++++++++++++++++----------------
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/src/modules/networkmanager/e_mod_main.c b/src/modules/networkmanager/e_mod_main.c
index 58bf47522..a144b3310 100644
--- a/src/modules/networkmanager/e_mod_main.c
+++ b/src/modules/networkmanager/e_mod_main.c
@@ -194,39 +194,40 @@ _enm_itc_group_wifi_text_get(void *data EINA_UNUSED, Evas_Object *obj EINA_UNUSE
return NULL;
}
-/* Toggle callback for the wireless group header on/off switch */
+/* Click callback for the wireless group header icon toggle */
static void
-_enm_wifi_toggle_changed(void *data, Evas_Object *obj,
- void *info EINA_UNUSED)
+_enm_wifi_icon_click_cb(void *data, Evas *e EINA_UNUSED,
+ Evas_Object *obj EINA_UNUSED,
+ void *event_info EINA_UNUSED)
{
E_NM_Instance *inst = data;
- E_NM_Module_Context *ctxt;
- if (!inst) return;
- ctxt = inst->ctxt;
- if (!ctxt || !ctxt->nm) return;
-
- enm_wireless_enabled_set(ctxt->nm, elm_check_state_get(obj));
+ if (!inst || !inst->ctxt || !inst->ctxt->nm) return;
+ enm_wireless_enabled_set(inst->ctxt->nm, !inst->ctxt->nm->wireless_enabled);
enm_mod_aps_update_now();
}
-/* Genlist content_get for the wireless group header: toggle in end slot */
+/* Genlist content_get for the wireless group header: icon toggle in end slot.
+ * Uses a plain elm_icon instead of elm_check to avoid the check widget's own
+ * hover/fade visual on mouse-over, which looks jarring in a header row. */
static Evas_Object *
_enm_itc_group_wifi_content_get(void *data, Evas_Object *obj,
const char *part)
{
E_NM_Instance *inst = data;
- Evas_Object *ck;
+ Evas_Object *ic;
if (!inst || !inst->ctxt || !inst->ctxt->nm) return NULL;
if (strcmp(part, "elm.swallow.end")) return NULL;
- ck = elm_check_add(obj);
- elm_check_state_set(ck, inst->ctxt->nm->wireless_enabled);
- evas_object_smart_callback_add(ck, "changed", _enm_wifi_toggle_changed, inst);
- evas_object_show(ck);
- evas_object_propagate_events_set(ck, EINA_FALSE);
- return ck;
+ ic = elm_icon_add(obj);
+ elm_icon_standard_set(ic, inst->ctxt->nm->wireless_enabled ?
+ "network-wireless" : "network-wireless-offline");
+ evas_object_propagate_events_set(ic, EINA_FALSE);
+ evas_object_event_callback_add(ic, EVAS_CALLBACK_MOUSE_UP,
+ _enm_wifi_icon_click_cb, inst);
+ evas_object_show(ic);
+ return ic;
}
/* Activated smart callback — handles connect/disconnect on row tap */
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
