This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch master
in repository enlightenment.
View the commit online.
commit 0b420bd75ddf37de402d4a1f7f574b40565f323c
Author: [email protected] <[email protected]>
AuthorDate: Sat Mar 14 19:24:42 2026 -0600
fix: restore WiFi signal strength and AP details in NetworkManager gadget
The gadget was showing only a blue dot instead of signal strength, lock
icon, and frequency band because of two interconnected issues:
1. get_wifi_props was calling GetAll on the Wireless interface proxy
instead of the D-Bus Properties proxy. GetAll is a Properties method,
not a Wireless method, so the D-Bus call always failed. This prevented
active_ap_path from being set, breaking the entire AP data chain.
2. AP properties (strength, security flags, frequency) were loaded
asynchronously via _ap_get_props_cb, but the gadget wasn't refreshed
after this callback completed, leaving stale display state if AP data
arrived after the active-connection probe.
Fix: Call GetAll on dev->proxy (the Properties proxy) instead of
dev->wireless_proxy, and refresh the gadget after AP properties arrive.
This restores the correct signal strength display, lock icon for security,
frequency band label, and traffic activity indicators.
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
---
src/modules/networkmanager/e_networkmanager.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/modules/networkmanager/e_networkmanager.c b/src/modules/networkmanager/e_networkmanager.c
index 8eb190d8d..3fee61041 100644
--- a/src/modules/networkmanager/e_networkmanager.c
+++ b/src/modules/networkmanager/e_networkmanager.c
@@ -236,6 +236,11 @@ _ap_get_props_cb(void *data, const Eldbus_Message *msg,
DBG("AP %s ssid=%s strength=%d", ap->path, ap->ssid ?: "(hidden)",
ap->strength);
+
+ /* Refresh gadget now that AP data (strength, security, frequency) is
+ * available — avoids leaving stale strength=0/no-lock state if this
+ * callback races ahead of the active-conn probe. */
+ _notify_manager_update(nm_manager);
}
static void
@@ -542,7 +547,7 @@ _device_get_props_cb(void *data, const Eldbus_Message *msg,
* with GetAccessPoints — this avoids the ActiveConnection.GetAll
* round-trip on the critical startup path. */
dev->pending.get_wifi_props =
- eldbus_proxy_call(dev->wireless_proxy, "GetAll",
+ eldbus_proxy_call(dev->proxy, "GetAll",
_device_wifi_props_cb, dev,
-1, "s", NM_IFACE_WIFI);
}
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
