[EGIT] [enlightenment-module-forecasts] 01/01: forecasts: fix mouse right-click.

[Enlightenment Git]

This is an automated email from the git hooks/post-receive script.

git pushed a commit to branch master
in repository enlightenment-module-forecasts.

View the commit online.

commit b47840fa331ff9263c43b12212c72f557a72b983
Author: Alastair Poole <nets...@netstar.im>
AuthorDate: Sun May 24 18:37:24 2026 +0100

    forecasts: fix mouse right-click.
---
 src/e_mod_main.c | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/src/e_mod_main.c b/src/e_mod_main.c
index 8b6942f..fd9d78a 100644
--- a/src/e_mod_main.c
+++ b/src/e_mod_main.c
@@ -110,8 +110,8 @@ struct _Forecasts
 };
 
 /* Module Function Protos */
-static void         _forecasts_cb_mouse_up(void *data, Evas *e, Evas_Object *obj,
-                                           void *event_info);
+static void         _forecasts_cb_mouse_down(void *data, Evas *e, Evas_Object *obj,
+                                             void *event_info);
 static void         _forecasts_menu_cb_configure(void *data, E_Menu *m,
                                                  E_Menu_Item *mi);
 static void         _forecasts_menu_cb_post(void *data, E_Menu *m);
@@ -191,8 +191,8 @@ _gc_init(E_Gadcon *gc, const char *name, const char *id, const char *style)
        ecore_event_handler_add(ECORE_CON_EVENT_URL_COMPLETE,
                                _forecasts_url_complete, inst);
 
-   evas_object_event_callback_add(w->forecasts_obj, EVAS_CALLBACK_MOUSE_UP,
-                                  _forecasts_cb_mouse_up, inst);
+   evas_object_event_callback_add(w->forecasts_obj, EVAS_CALLBACK_MOUSE_DOWN,
+                                  _forecasts_cb_mouse_down, inst);
    forecasts_config->instances =
      eina_list_append(forecasts_config->instances, inst);
 
@@ -234,8 +234,8 @@ _gc_shutdown(E_Gadcon_Client *gcc)
    forecasts_config->instances =
      eina_list_remove(forecasts_config->instances, inst);
 
-   evas_object_event_callback_del(w->forecasts_obj, EVAS_CALLBACK_MOUSE_UP,
-                                  _forecasts_cb_mouse_up);
+   evas_object_event_callback_del(w->forecasts_obj, EVAS_CALLBACK_MOUSE_DOWN,
+                                  _forecasts_cb_mouse_down);
 
    _forecasts_free(w);
    E_FREE(inst);
@@ -293,16 +293,17 @@ _gc_id_new(const E_Gadcon_Client_Class *client_class EINA_UNUSED)
 }
 
 static void
-_forecasts_cb_mouse_up(void *data, Evas *e EINA_UNUSED,
-                       Evas_Object *obj EINA_UNUSED,
-                       void *event_info)
+_forecasts_cb_mouse_down(void *data, Evas *e EINA_UNUSED,
+                         Evas_Object *obj EINA_UNUSED,
+                         void *event_info)
 {
    Instance *inst = data;
-   Evas_Event_Mouse_Up *ev = event_info;
+   Evas_Event_Mouse_Down *ev = event_info;
 
    if (ev->event_flags & EVAS_EVENT_FLAG_ON_HOLD) return;
    if ((ev->button == 3) && (!forecasts_config->menu))
      {
+        E_Zone *zone;
         E_Menu *m;
         E_Menu_Item *mi;
         int x, y, w, h;
@@ -318,10 +319,11 @@ _forecasts_cb_mouse_up(void *data, Evas *e EINA_UNUSED,
         forecasts_config->menu = m;
 
         e_gadcon_canvas_zone_geometry_get(inst->gcc->gadcon, &x, &y, &w, &h);
-        e_menu_activate_mouse(m,
-                              e_zone_current_get(), x + ev->output.x,
+        zone = inst->gcc->gadcon->zone;
+        if (!zone) zone = e_zone_current_get();
+        e_menu_activate_mouse(m, zone, x + ev->output.x,
                               y + ev->output.y, 1, 1,
-                              E_MENU_POP_DIRECTION_DOWN, ev->timestamp);
+                              E_MENU_POP_DIRECTION_AUTO, ev->timestamp);
         evas_event_feed_mouse_up(inst->gcc->gadcon->evas, ev->button,
                                  EVAS_BUTTON_NONE, ev->timestamp, NULL);
      }


-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.