This is an automated email from the git hooks/post-receive script.
git pushed a commit to reference refs/pull/36/head
in repository terminology.
View the commit online.
commit 07cc000f70cb07cad8f73ec5aac9a30ea6b6493b
Author: [email protected] <[email protected]>
AuthorDate: Sun Jun 7 13:32:37 2026 -0600
fix(tymux): restore hyperlinks in shadow pty scrollback
termpty_cell_get() returned NULL for backlog rows when querying a
shadow pty (where ty->back is NULL), because it never consulted the
backlog_get callback. Scrollback in tymux sessions is served exclusively
via that callback, not via ty->back. This caused OSC-8 hyperlinks that
scrolled into history to become unclickable — _smart_mouseover_apply()
gates link detection on termpty_cell_get() and bailed out early.
Route the backlog path through _termpty_cellrow_live_get(), the same
helper already used by termpty_cellrow_get(), to honor the callback.
This is a no-op for standard ptys (which allocate ty->back) and restores
clickability for hyperlinks in tymux scrollback.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
---
src/bin/termpty.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/bin/termpty.c b/src/bin/termpty.c
index 61567c7c..41b684e6 100644
--- a/src/bin/termpty.c
+++ b/src/bin/termpty.c
@@ -1274,10 +1274,10 @@ termpty_cell_get(Termpty *ty, int y_requested, int x_requested)
return NULL;
return &(TERMPTY_SCREEN(ty, 0, y_requested)) + x_requested;
}
- if (!ty->back)
- return NULL;
-
- cells = _termpty_cellrow_from_beacon_get(ty, y_requested, &wret);
+ /* Route through _termpty_cellrow_live_get so that the backlog_get
+ * callback is honoured for tymux shadow ptys (ty->back is NULL there;
+ * backlog rows are served exclusively via the callback). */
+ cells = _termpty_cellrow_live_get(ty, y_requested, &wret);
if (!cells || x_requested >= wret)
return NULL;
return cells + x_requested;
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
