This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch nm-vpn-username-capture
in repository enlightenment.
View the commit online.
commit e7469b2904b3bb92d6f58a7fe1efb011aefcb30a
Author: [email protected] <[email protected]>
AuthorDate: Sun Jun 21 21:01:00 2026 -0600
networkmanager: harden username dialog/probe (review fixes)
E_NEW NULL guard in enm_vpn_username_dialog and strdup OOM guard in the
post-import probe, per Task 2-3 review.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
---
.../networkmanager/e_networkmanager_vpn_username.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/src/modules/networkmanager/e_networkmanager_vpn_username.c b/src/modules/networkmanager/e_networkmanager_vpn_username.c
index 72019207a..6cde815f0 100644
--- a/src/modules/networkmanager/e_networkmanager_vpn_username.c
+++ b/src/modules/networkmanager/e_networkmanager_vpn_username.c
@@ -207,6 +207,7 @@ enm_vpn_username_dialog(const char *conn_name, const char *type_label,
if (!dialog) { if (cb) cb(data, NULL); return; }
ud = E_NEW(Username_Dialog, 1);
+ if (!ud) { e_object_del(E_OBJECT(dialog)); if (cb) cb(data, NULL); return; }
ud->dialog = dialog;
ud->cb = cb;
ud->data = ""
@@ -354,11 +355,15 @@ _probe_on_del(void *data, int type EINA_UNUSED, void *event)
if (svc) { char *d = strrchr(svc, '.'); short_name = d ? d + 1 : svc; }
if (enm_vpn_username_needed(short_name, conn_type, username))
- enm_vpn_username_dialog(ctx->conn_name,
- short_name, /* type label: short name */
- username,
- _probe_username_entered,
- strdup(ctx->conn_name));
+ {
+ char *name_copy = strdup(ctx->conn_name);
+ if (name_copy)
+ enm_vpn_username_dialog(ctx->conn_name,
+ short_name, /* type label: short name */
+ username,
+ _probe_username_entered,
+ name_copy);
+ }
free(svc); free(conn_type); free(username);
free(ctx->conn_name);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
