This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch nm-vpn-username-capture
in repository enlightenment.
View the commit online.
commit facb1b43cd34149f00244f5f1cf301a2ea28ddaa
Author: [email protected] <[email protected]>
AuthorDate: Sun Jun 21 21:10:30 2026 -0600
networkmanager: pin LC_ALL=C for parsed nmcli output
Localized nmcli banners/field output would break connection-name parsing
and silently skip the username prompt. Per final review.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
---
src/modules/networkmanager/e_networkmanager_import.c | 4 +++-
src/modules/networkmanager/e_networkmanager_vpn_username.c | 3 ++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/modules/networkmanager/e_networkmanager_import.c b/src/modules/networkmanager/e_networkmanager_import.c
index 1808c8e39..b17060edb 100644
--- a/src/modules/networkmanager/e_networkmanager_import.c
+++ b/src/modules/networkmanager/e_networkmanager_import.c
@@ -213,8 +213,10 @@ enm_import_run(const char *type, const char *file_path,
}
char cmd[4096];
+ /* LC_ALL=C so the "Connection 'NAME' ... added" banner we parse for the
+ * connection name is not localized. */
snprintf(cmd, sizeof(cmd),
- "'%s' connection import type '%s' file '%s'",
+ "LC_ALL=C '%s' connection import type '%s' file '%s'",
esc_nmcli, esc_type, esc_filepath);
free(esc_nmcli);
diff --git a/src/modules/networkmanager/e_networkmanager_vpn_username.c b/src/modules/networkmanager/e_networkmanager_vpn_username.c
index 6cde815f0..18b059a50 100644
--- a/src/modules/networkmanager/e_networkmanager_vpn_username.c
+++ b/src/modules/networkmanager/e_networkmanager_vpn_username.c
@@ -387,8 +387,9 @@ enm_vpn_username_maybe_prompt(const char *conn_name)
esc_name = _username_shell_escape(conn_name);
if (!esc_nmcli || !esc_name) { free(esc_nmcli); free(esc_name); return; }
+ /* LC_ALL=C for stable, non-localized -g field output we parse below. */
snprintf(cmd, sizeof(cmd),
- "'%s' -g vpn.service-type,vpn.data connection show '%s'",
+ "LC_ALL=C '%s' -g vpn.service-type,vpn.data connection show '%s'",
esc_nmcli, esc_name);
free(esc_nmcli); free(esc_name);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
