This is an automated email from the git hooks/post-receive script.
git pushed a commit to branch wl/browser-all
in repository enlightenment.
View the commit online.
commit 891b74ba4bb77eca9ae4016b5ec1f385f04b1a31
Author: Cedric BAIL <[email protected]>
AuthorDate: Mon Aug 17 00:53:30 2026 -0600
tests - put the second screen next to the first one, not on top of it
The browser test added its second zone at a hardcoded x=1024, which is exactly
right on the buffer backend and wrong on x11, where E's window is 1280 wide:
the new zone landed inside the old one, E moved the window to it without moving
it anywhere, and the test correctly complained that a window on output 1 was
sitting at +0+0.
Place it at the maximised width instead, which is the usable width of the
screen the window is already on, whatever that screen turns out to be.
Firefox, Chromium and Brave now pass on both backends. Worth noting from the
x11 runs: Firefox navigates there - "e-browser-probe - Mozilla Firefox" - so
its refusal to open a URL from the command line is not universal, and the note
about it in test_browser.c is narrower than it reads.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
---
src/tests/wayland/test_browser.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/tests/wayland/test_browser.c b/src/tests/wayland/test_browser.c
index 57727b777..3eb82450e 100644
--- a/src/tests/wayland/test_browser.c
+++ b/src/tests/wayland/test_browser.c
@@ -184,16 +184,21 @@ main(int argc, char **argv)
* one screen, so without wl_test.zone_add there is nothing to move to -
* and "drag the browser to the other monitor" is a thing people do all day
* and a thing that has to survive a client that decorates itself. */
- tk_zone_add(tk, 1024, 0, 1024, 768);
+ /* Immediately to the right of the screen there is, not at a number chosen
+ * here: the zone is 1024x768 on the buffer backend and 1280x720 on x11, and
+ * a second zone placed on top of the first is not a second screen. mw is
+ * the maximised width, which is the usable width of zone 0. */
+ tk_zone_add(tk, mw, 0, mw, mh);
tk_action(tk, id, "window_zone_move_by", "1");
c = tk_expect(tk, app_id);
if (c->output == 0)
tk_fail(tk, "after moving to the next screen the window is still on "
"output 0, at %dx%d+%d+%d", c->w, c->h, c->x, c->y);
- if (c->x < 1024)
+ if (c->x < mw)
tk_fail(tk, "the window says it is on output %u but sits at +%d+%d, "
- "which is on the first screen", c->output, c->x, c->y);
+ "which is still on the first screen (%d wide)",
+ c->output, c->x, c->y, mw);
if ((c->w != w0) || (c->h != h0))
tk_fail(tk, "moving to another screen resized the window to %dx%d, "
"was %dx%d", c->w, c->h, w0, h0);
--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
