On Sat, 7 Jul 2007 07:14:20 +0200 (CEST) Vincent Torri <[EMAIL PROTECTED]>
babbled:
>
>
> On Fri, 6 Jul 2007, Enlightenment CVS wrote:
> > style = EVAS_TEXT_STYLE_OUTLINE_SHADOW;
> > else if (ep->part->effect ==
> > EDJE_TEXT_EFFECT_OUTLINE_SOFT_SHADOW) style =
> > EVAS_TEXT_STYLE_OUTLINE_SOFT_SHADOW;
> > + else if (ep->part->effect == EDJE_TEXT_EFFECT_FAR_SHADOW)
> > + style = EVAS_TEXT_STYLE_FAR_SHADOW;
> > + else if (ep->part->effect == EDJE_TEXT_EFFECT_FAR_SOFT_SHADOW)
> > + style = EVAS_TEXT_STYLE_FAR_SOFT_SHADOW;
> > + else if (ep->part->effect == EDJE_TEXT_EFFECT_GLOW)
> > + style = EVAS_TEXT_STYLE_GLOW;
>
> > #define EDJE_TEXT_EFFECT_SOFT_SHADOW 5
> > #define EDJE_TEXT_EFFECT_OUTLINE_SHADOW 6
> > #define EDJE_TEXT_EFFECT_OUTLINE_SOFT_SHADOW 7
> > -#define EDJE_TEXT_EFFECT_LAST 8
> > +#define EDJE_TEXT_EFFECT_FAR_SHADOW 8
> > +#define EDJE_TEXT_EFFECT_FAR_SOFT_SHADOW 9
> > +#define EDJE_TEXT_EFFECT_GLOW 10
> > +#define EDJE_TEXT_EFFECT_LAST 11
>
> Isn't it better to use an enum + a switch, instead of defines + if/else ?
even better is a lookup table
const styles[] = {EVAS_TEXT_STYLE_PLAIN, EVAS_TEXT_STYLE_SHADOW, ... };
if ((effect >= 0) && (effect < EDJE_TEXT_EFFECT_LAST)) style = styles[effect];
else style = EVAS_TEXT_STYLE_PLAIN;
> Vincent
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
--
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler) [EMAIL PROTECTED]
裸好多
Tokyo, Japan (東京 日本)
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
