On 7/21/07, Enlightenment CVS <[EMAIL PROTECTED]> wrote:
> Enlightenment CVS committal
>
> Author  : raster
> Project : e17
> Module  : libs/evas
>
> Dir     : e17/libs/evas/src/lib/canvas
>
>
> Modified Files:
>         evas_object_textblock.c
>
>
> Log Message:
>
>
> no need for extra nul byte check - while terminated IF its null. so known
> condition. formatting too.
>
> ===================================================================
> RCS file: /cvs/e/e17/libs/evas/src/lib/canvas/evas_object_textblock.c,v
> retrieving revision 1.141
> retrieving revision 1.142
> diff -u -3 -r1.141 -r1.142
> --- evas_object_textblock.c     20 Jul 2007 22:30:12 -0000      1.141
> +++ evas_object_textblock.c     21 Jul 2007 03:06:08 -0000      1.142

[...]

> @@ -2463,7 +2462,7 @@
>              evas_textblock_cursor_text_append(cur, map_itr);
>              return;
>           }
> -
> +
>         if (map_itr < map_itr)
>           _advance_after_end_of_string(&map_itr);
>       }
>

is this trailing whitespace really required? :-) I have emacs to
highlight these on my files.


still about minor optimizations, do you think it worth to remove "&"
and ";" since they're always present?


-- 
Gustavo Sverzut Barbieri
--------------------------------------
Jabber: [EMAIL PROTECTED]
   MSN: [EMAIL PROTECTED]
  ICQ#: 17249123
 Skype: gsbarbieri
Mobile: +55 (81) 9927 0010

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to